* [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
@ 2014-05-13 12:25 arei.gonglei
2014-06-10 7:20 ` Amit Shah
2014-06-10 17:26 ` Juan Quintela
0 siblings, 2 replies; 4+ messages in thread
From: arei.gonglei @ 2014-05-13 12:25 UTC (permalink / raw)
To: qemu-devel
Cc: yamahata, weidong.huang, quintela, mjt, owasserm, Gonglei,
mrhines, Mo Yuxiang, pbonzini
From: Gonglei <arei.gonglei@huawei.com>
If the networking break or there's something wrong with rdma
device(ib0 with no IP) during rdma migration, the main_loop of
qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
to fix this bug.
Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
---
v2:
- add reviewed-by.
migration-rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration-rdma.c b/migration-rdma.c
index eeb4302..f60749b 100644
--- a/migration-rdma.c
+++ b/migration-rdma.c
@@ -949,6 +949,7 @@ route:
ERROR(errp, "result not equal to event_addr_resolved %s",
rdma_event_str(cm_event->event));
perror("rdma_resolve_addr");
+ rdma_ack_cm_event(cm_event);
ret = -EINVAL;
goto err_resolve_get_addr;
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
2014-05-13 12:25 [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration arei.gonglei
@ 2014-06-10 7:20 ` Amit Shah
2014-06-10 9:25 ` Gonglei (Arei)
2014-06-10 17:26 ` Juan Quintela
1 sibling, 1 reply; 4+ messages in thread
From: Amit Shah @ 2014-06-10 7:20 UTC (permalink / raw)
To: arei.gonglei
Cc: yamahata, weidong.huang, quintela, mjt, qemu-devel, owasserm,
mrhines, pbonzini, Mo Yuxiang
On (Tue) 13 May 2014 [20:25:38], arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> If the networking break or there's something wrong with rdma
> device(ib0 with no IP) during rdma migration, the main_loop of
> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> to fix this bug.
>
> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
2014-06-10 7:20 ` Amit Shah
@ 2014-06-10 9:25 ` Gonglei (Arei)
0 siblings, 0 replies; 4+ messages in thread
From: Gonglei (Arei) @ 2014-06-10 9:25 UTC (permalink / raw)
To: Amit Shah, Juan Quintela
Cc: yamahata@private.email.ne.jp, Huangweidong (C), mjt@tls.msk.ru,
qemu-devel@nongnu.org, owasserm@redhat.com, mrhines@us.ibm.com,
pbonzini@redhat.com, Moyuxiang
> -----Original Message-----
> From: Amit Shah [mailto:amit.shah@redhat.com]
> Sent: Tuesday, June 10, 2014 3:20 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; yamahata@private.email.ne.jp; Huangweidong
> (C); quintela@redhat.com; mjt@tls.msk.ru; owasserm@redhat.com;
> mrhines@us.ibm.com; Moyuxiang; pbonzini@redhat.com
> Subject: Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
>
> On (Tue) 13 May 2014 [20:25:38], arei.gonglei@huawei.com wrote:
> > From: Gonglei <arei.gonglei@huawei.com>
> >
> > If the networking break or there's something wrong with rdma
> > device(ib0 with no IP) during rdma migration, the main_loop of
> > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> > to fix this bug.
> >
> > Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> > Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> > Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Amit
Thanks.
Juan, do you plan to apply this patch?
Best regards,
-Gonglei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration
2014-05-13 12:25 [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration arei.gonglei
2014-06-10 7:20 ` Amit Shah
@ 2014-06-10 17:26 ` Juan Quintela
1 sibling, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2014-06-10 17:26 UTC (permalink / raw)
To: arei.gonglei
Cc: yamahata, weidong.huang, mjt, qemu-devel, owasserm, mrhines,
pbonzini, Mo Yuxiang
<arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> If the networking break or there's something wrong with rdma
> device(ib0 with no IP) during rdma migration, the main_loop of
> qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> to fix this bug.
>
> Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Michael R. Hines <mrhines@us.ibm.com>
> ---
> v2:
> - add reviewed-by.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-10 17:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 12:25 [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration arei.gonglei
2014-06-10 7:20 ` Amit Shah
2014-06-10 9:25 ` Gonglei (Arei)
2014-06-10 17:26 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).