From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43188)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1WuGXl-0005eT-9p
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 03:32:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1WuGXg-0005BW-5E
	for qemu-devel@nongnu.org; Tue, 10 Jun 2014 03:32:29 -0400
Date: Tue, 10 Jun 2014 13:01:46 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140610073146.GJ27148@grmbl.mre>
References: <1401485884-25500-1-git-send-email-pl@kamp.de>
	<20140603172714.GH3017@work-vm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140603172714.GH3017@work-vm>
Subject: Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in
 ram_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: pbonzini@redhat.com, quintela@redhat.com, Peter Lieven <pl@kamp.de>, qemu-stable@nongnu.org, qemu-devel@nongnu.org

On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
> * Peter Lieven (pl@kamp.de) wrote:
> > if a saved vm has unknown flags in the memory data qemu
> > currently simply ignores this flag and continues which
> > yields in an unpredictable result.
> > 
> > this patch catches all unknown flags and
> > aborts the loading of the vm.
> 
> Yes, I think that's quite nice - the only thing I'd add which would help
> a little is an error_report() in the case where you have invalid flags
> to let you know that's the reason for the EINVAL.
> 
> (Having spent the day tracking down migration bugs...)

Peter, can you please add these before we pick the patch up?

Thanks,

		Amit