From: Amit Shah <amit.shah@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: quintela@redhat.com, qemu-stable@nongnu.org,
qemu-devel@nongnu.org, pbonzini@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load
Date: Tue, 10 Jun 2014 14:33:28 +0530 [thread overview]
Message-ID: <20140610090328.GC10960@grmbl.mre> (raw)
In-Reply-To: <5396C63C.6010302@kamp.de>
On (Tue) 10 Jun 2014 [10:47:56], Peter Lieven wrote:
> On 10.06.2014 10:45, Amit Shah wrote:
> >On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote:
> >>if a saved vm has unknown flags in the memory data qemu
> >>currently simply ignores this flag and continues which
> >>yields in an unpredictable result.
> >>
> >>this patch catches all unknown flags and
> >>aborts the loading of the vm.
> >>
> >>CC: qemu-stable@nongnu.org
> >>Signed-off-by: Peter Lieven <pl@kamp.de>
> >Reviewed-by: Amit Shah <amit.shah@redhat.com>
> >
> >>---
> >>v2->v3: - reworked last case in the if statement
> >> - added an error_report in case of an unknown flag [David]
> >Thanks. Would be nice to get an error_report() for the other error
> >conditions, too. It's not fun to learn migration has failed, w/o any
> >clue of why or where.
>
> Ok, will send v4.
Thank you!
Amit
next prev parent reply other threads:[~2014-06-10 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 8:04 [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load Peter Lieven
2014-06-10 8:45 ` Amit Shah
2014-06-10 8:47 ` Peter Lieven
2014-06-10 9:03 ` Amit Shah [this message]
2014-06-10 9:30 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610090328.GC10960@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).