From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuHyJ-0001Iw-Ua for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuHyB-0004om-Ps for qemu-devel@nongnu.org; Tue, 10 Jun 2014 05:03:59 -0400 Date: Tue, 10 Jun 2014 14:33:28 +0530 From: Amit Shah Message-ID: <20140610090328.GC10960@grmbl.mre> References: <1402387463-17246-1-git-send-email-pl@kamp.de> <20140610084535.GB10960@grmbl.mre> <5396C63C.6010302@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5396C63C.6010302@kamp.de> Subject: Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: quintela@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, dgilbert@redhat.com On (Tue) 10 Jun 2014 [10:47:56], Peter Lieven wrote: > On 10.06.2014 10:45, Amit Shah wrote: > >On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote: > >>if a saved vm has unknown flags in the memory data qemu > >>currently simply ignores this flag and continues which > >>yields in an unpredictable result. > >> > >>this patch catches all unknown flags and > >>aborts the loading of the vm. > >> > >>CC: qemu-stable@nongnu.org > >>Signed-off-by: Peter Lieven > >Reviewed-by: Amit Shah > > > >>--- > >>v2->v3: - reworked last case in the if statement > >> - added an error_report in case of an unknown flag [David] > >Thanks. Would be nice to get an error_report() for the other error > >conditions, too. It's not fun to learn migration has failed, w/o any > >clue of why or where. > > Ok, will send v4. Thank you! Amit