qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Liuyongan <liuyongan@huawei.com>,
	aliguori@amazon.com, Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest
Date: Tue, 10 Jun 2014 13:10:32 +0300	[thread overview]
Message-ID: <20140610101032.GJ7423@redhat.com> (raw)
In-Reply-To: <20140610062033.GG27148@grmbl.mre>

On Tue, Jun 10, 2014 at 11:50:33AM +0530, Amit Shah wrote:
> On (Tue) 20 May 2014 [14:01:44], Jason Wang wrote:
> > It's hard to track all mac addresses and their configurations (e.g
> > vlan or ipv6) in qemu. Without this information, it's impossible to
> > build proper garp packet after migration. The only possible solution
> > to this is let guest (who knows all configurations) to do this.
> > 
> > So, this patch introduces a new readonly config status bit of virtio-net,
> > VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce
> > presence of its link through config update interrupt.When guest has
> > done the announcement, it should ack the notification through
> > VIRTIO_NET_CTRL_ANNOUNCE_ACK cmd. This feature is negotiated by a new
> > feature bit VIRTIO_NET_F_ANNOUNCE (which has already been supported by
> > Linux guest).
> > 
> > During load, a counter of announcing rounds is set so that after the vm is
> > running it can trigger rounds of config interrupts to notify the guest to build
> > and send the correct garps.
> 
> Live migration is supposed to be transparent to guests.
> 
> Doing things this way makes the guest involved in live migration.
> It's not desirable.

I'm not sure there's a problem.
As long as guest doesn't use networking, it does not
need to be involved. If guest does want to use networking,
it needs to be involved, but then it's accessing the
device anyway.

> For networking, this may well be not possible.
> Are there any ways of doing this w/o involving the guest that have
> been considered?
> 
> 
> 		Amit

Since we don't know guest addresses, this looks like the only way to me.

-- 
MST

  reply	other threads:[~2014-06-10 10:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-20  6:01 [Qemu-devel] [PATCH V2 0/3] virtio-net: announce self by guest Jason Wang
2014-05-20  6:01 ` [Qemu-devel] [PATCH V2 1/3] migration: export SELF_ANNOUNCE_ROUNDS Jason Wang
2014-05-20  6:01 ` [Qemu-devel] [PATCH V2 2/3] migration: introduce self_announce_delay() Jason Wang
2014-05-20  6:01 ` [Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest Jason Wang
2014-06-10  6:20   ` Amit Shah
2014-06-10 10:10     ` Michael S. Tsirkin [this message]
2014-06-11  2:50       ` Jason Wang
2014-06-13 12:35         ` Amit Shah
2014-06-11 14:42 ` [Qemu-devel] [PATCH V2 0/3] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140610101032.GJ7423@redhat.com \
    --to=mst@redhat.com \
    --cc=akong@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=liuyongan@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).