From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/6] monitor: protect outbuf with mutex
Date: Tue, 10 Jun 2014 10:28:12 -0400 [thread overview]
Message-ID: <20140610102812.4d783438@redhat.com> (raw)
In-Reply-To: <5397151D.1050700@redhat.com>
On Tue, 10 Jun 2014 16:24:29 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 10/06/2014 16:10, Luiz Capitulino ha scritto:
> >> > + qemu_mutex_lock(&hmp.out_lock);
> >> > if (qstring_get_length(hmp.outbuf) > 0) {
> >> > output = g_strdup(qstring_get_str(hmp.outbuf));
> >> > } else {
> >> > output = g_strdup("");
> >> > }
> >> > + qemu_mutex_unlock(&hmp.out_lock);
> > Are you sure we need to lock/unlock in this function? hmp is allocated
> > in the stack.
> >
>
> No, we don't but it was more obvious to me this way (and looking at it
> again, I'm pretty sure that some static analyzer would complain without
> these).
Fine, I'm OK with that.
next prev parent reply other threads:[~2014-06-10 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 16:39 [Qemu-devel] [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe Paolo Bonzini
2014-06-03 16:39 ` [Qemu-devel] [PATCH 1/6] qemu-char: introduce qemu_chr_alloc Paolo Bonzini
2014-06-11 6:28 ` Fam Zheng
2014-06-03 16:39 ` [Qemu-devel] [PATCH 2/6] qemu-char: do not call chr_write directly Paolo Bonzini
2014-06-11 6:30 ` Fam Zheng
2014-06-03 16:39 ` [Qemu-devel] [PATCH 3/6] qemu-char: move pty_chr_update_read_handler around Paolo Bonzini
2014-06-11 6:32 ` Fam Zheng
2014-06-03 16:39 ` [Qemu-devel] [PATCH 4/6] qemu-char: make writes thread-safe Paolo Bonzini
2014-06-11 6:59 ` Fam Zheng
2014-06-11 8:16 ` Paolo Bonzini
2014-06-03 16:39 ` [Qemu-devel] [PATCH 5/6] monitor: protect outbuf with mutex Paolo Bonzini
2014-06-10 14:10 ` Luiz Capitulino
2014-06-10 14:24 ` Paolo Bonzini
2014-06-10 14:28 ` Luiz Capitulino [this message]
2014-06-03 16:39 ` [Qemu-devel] [PATCH 6/6] monitor: protect event emission Paolo Bonzini
2014-06-10 13:33 ` Luiz Capitulino
2014-06-27 9:43 ` [Qemu-devel] [PATCH 0/5] qemu-char/monitor: make monitor_puts thread safe Stefan Hajnoczi
2014-06-27 12:33 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140610102812.4d783438@redhat.com \
--to=lcapitulino@redhat.com \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).