From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wugl9-0008Rl-0q for qemu-devel@nongnu.org; Wed, 11 Jun 2014 07:32:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wugl4-00069f-5G for qemu-devel@nongnu.org; Wed, 11 Jun 2014 07:32:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wugl3-00068k-U6 for qemu-devel@nongnu.org; Wed, 11 Jun 2014 07:31:58 -0400 Date: Wed, 11 Jun 2014 13:31:21 +0200 From: Stefan Hajnoczi Message-ID: <20140611113121.GH6673@stefanha-thinkpad.str.redhat.com> References: <1402392027-9164-1-git-send-email-arei.gonglei@huawei.com> <1402392027-9164-3-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fd5uyaI9j6xoeUBo" Content-Disposition: inline In-Reply-To: <1402392027-9164-3-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v3 2/4] qemu-bridge-helper: Fix fd leak in main() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com Cc: weidong.huang@huawei.com, luonengjun@huawei.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com, pbonzini@redhat.com --fd5uyaI9j6xoeUBo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 10, 2014 at 05:20:25PM +0800, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > initialize fd and ctlfd, and close them at the end >=20 > Signed-off-by: Gonglei > --- > qemu-bridge-helper.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan --fd5uyaI9j6xoeUBo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTmD4JAAoJEJykq7OBq3PIDzcIAMXAZaulciSp5v/3iJ77b1QR d1llxMry3AKRW6pLJVB4H6yaueDosuPRBIEcskMzBW7ayXi9CMF+2oEaazjkPOcI gLT/NMU7EzMstUx13ZwWJmcNGsjFBpImjpd1uomg86iUWv8do4oOuSn2YX2mxAjZ Pwq6HdfqdVLGfUpD3SG7A01szvz78qyDdFv6f9YCnzJQW3sh3M1kKn8TC8mLHm78 hL/fADe84aCq6iau0VXO0w7/5iowJqD9tvvXCnN+l7yNkoHZfi/t7oWH5aReLu6C C5QDEICBQ8sWaXjuF9ALsjTnTYa3BbI10VVKWxait4ARwgQ8otRwd5PkTImGIAk= =Eda6 -----END PGP SIGNATURE----- --fd5uyaI9j6xoeUBo--