From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Wuv9E-0004oB-1I
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 22:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Wuv96-0008NS-Uf
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 22:53:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46074)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Wuv96-0008N8-Lt
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 22:53:44 -0400
Date: Thu, 12 Jun 2014 10:53:55 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140612025355.GJ5448@T430.nay.redhat.com>
References: <1402168324-28931-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402168324-28931-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: Add includes from qapi/ as
	dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit@irqsave.net>

On Sat, 06/07 21:12, Max Reitz wrote:
> qapi-schema.json has been split into three smaller JSON files in qapi/.
> Add them as dependencies for the code generation in the Makefile, so
> changes to them will result in a rebuilt of all QAPI-dependent code.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  Makefile | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d830483..7837865 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -246,18 +246,21 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
>  		$(gen-out-type) -o qga/qapi-generated -p "qga-" -i $<, \
>  		"  GEN   $@")
>  
> +qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \
> +               $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core.json
> +
>  qapi-types.c qapi-types.h :\
> -$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
> +$(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py)
>  	$(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-types.py \
>  		$(gen-out-type) -o "." -b -i $<, \
>  		"  GEN   $@")
>  qapi-visit.c qapi-visit.h :\
> -$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-visit.py $(qapi-py)
> +$(qapi-modules) $(SRC_PATH)/scripts/qapi-visit.py $(qapi-py)
>  	$(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-visit.py \
>  		$(gen-out-type) -o "." -b -i $<, \
>  		"  GEN   $@")
>  qmp-commands.h qmp-marshal.c :\
> -$(SRC_PATH)/qapi-schema.json $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
> +$(qapi-modules) $(SRC_PATH)/scripts/qapi-commands.py $(qapi-py)
>  	$(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-commands.py \
>  		$(gen-out-type) -o "." -m -i $<, \
>  		"  GEN   $@")
> -- 
> 2.0.0
> 

Reviewed-by: Fam Zheng <famz@redhat.com>