Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jun 12, 2014 at 03:53:00PM +0800, Hu Tao wrote:
> On Thu, Jun 12, 2014 at 10:41:18AM +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 10, 2014 at 07:15:13PM +0800, Hu Tao wrote:
> > > note: based on MST's numa tree.
> > > 
> > > changes are error messages and docs tweaks to address comments to
> > > v4.
> > 
> > Applied, numa tree applied to the pci tree as well.
> > Two points I would like to see addressed before it's going upstream:
> > 	- please validate and test the pci branch
> > 	  there have been lots of changes
> > 	- please work to drop the SignedRange: for all
> > 	  current purposes existing Range is sufficient,
> > 	  instead of a list and sort re-implementation, it is
> > 	  better to use g_list_insert_sorted
> 
> I see. Thanks for your work!

Could you confirm you'll be able to fix these by Monday?
I'd like to send the pull request then.

> > 
> > Thanks everyone.
> > 
> > > 
> > > Hu Tao (7):
> > >   backend:hostmem: replace hostmemory with host_memory
> > >   hostmem: separate allocation from UserCreatable complete method
> > >   hostmem: add properties for NUMA memory policy
> > >   tests: fix memory leak in test of string input visitor
> > >   qapi: make string input visitor parse int list
> > >   qapi: make string output visitor parse int list
> > >   qmp: add query-memdev
> > > 
> > > Paolo Bonzini (8):
> > >   vl: redo -object parsing
> > >   fixup! qmp: improve error reporting for -object and object-add
> > >   pc: pass MachineState to pc_memory_init
> > >   fixup! numa: add -numa node,memdev= option
> > >   hostmem: add file-based HostMemoryBackend
> > >   hostmem: add merge and dump properties
> > >   hostmem: allow preallocation of any memory region
> > >   hostmem: add property to map memory with MAP_SHARED
> > > 
> > > Wanlong Gao (1):
> > >   fixup! NUMA: check if the total numa memory size is equal to ram_size
> > > 
> > >  backends/Makefile.objs             |   1 +
> > >  backends/hostmem-file.c            | 134 ++++++++++++++++
> > >  backends/hostmem-ram.c             |   7 +-
> > >  backends/hostmem.c                 | 304 +++++++++++++++++++++++++++++++++++--
> > >  exec.c                             |  25 ++-
> > >  hw/i386/pc.c                       |  24 +--
> > >  hw/i386/pc_piix.c                  |   8 +-
> > >  hw/i386/pc_q35.c                   |   4 +-
> > >  include/exec/memory.h              |  12 ++
> > >  include/exec/ram_addr.h            |   4 +-
> > >  include/hw/i386/pc.h               |   7 +-
> > >  include/qemu/osdep.h               |  10 ++
> > >  include/sysemu/hostmem.h           |   8 +
> > >  memory.c                           |  14 +-
> > >  numa.c                             |  78 +++++++++-
> > >  qapi-schema.json                   |  60 ++++++++
> > >  qapi/string-input-visitor.c        | 181 +++++++++++++++++++++-
> > >  qapi/string-output-visitor.c       | 230 ++++++++++++++++++++++++++--
> > >  qemu-options.hx                    |   6 +-
> > >  qmp-commands.hx                    |  38 +++++
> > >  qmp.c                              |   3 +-
> > >  tests/test-string-input-visitor.c  |  39 +++++
> > >  tests/test-string-output-visitor.c |  34 +++++
> > >  vl.c                               |  65 ++++----
> > >  24 files changed, 1191 insertions(+), 105 deletions(-)
> > >  create mode 100644 backends/hostmem-file.c
> > > 
> > > -- 
> > > 1.9.3