From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvN8D-0003H7-PF for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:46:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvN87-0001AB-N7 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:46:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvN87-00019w-E7 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:46:35 -0400 Date: Fri, 13 Jun 2014 11:46:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20140613084656.GA2414@redhat.com> References: <20140612074118.GA19354@redhat.com> <20140612075300.GC3720@G08FNSTD100614.fnst.cn.fujitsu.com> <20140613080301.GC2117@redhat.com> <539AB3E4.4090404@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <539AB3E4.4090404@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Eduardo Habkost , Hu Tao , qemu-devel@nongnu.org, Yasunori Goto , Igor Mammedov On Fri, Jun 13, 2014 at 10:18:44AM +0200, Paolo Bonzini wrote: > Il 13/06/2014 10:03, Michael S. Tsirkin ha scritto: > >>>> > Two points I would like to see addressed before it's going upstream: > >>>> > - please validate and test the pci branch > >>>> > there have been lots of changes > >>>> > - please work to drop the SignedRange: for all > >>>> > current purposes existing Range is sufficient, > >>>> > instead of a list and sort re-implementation, it is > >>>> > better to use g_list_insert_sorted > >>> > >>> I see. Thanks for your work! > >Could you confirm you'll be able to fix these by Monday? > >I'd like to send the pull request then. > > I think SignedRange can be dealt with after the merge. > > Paolo Could be, but let's not go there, cleaning this up isn't hard. -- MST