From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvNFL-00082B-75 for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvNFF-0004HM-1c for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:54:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvNFE-0004H7-OJ for qemu-devel@nongnu.org; Fri, 13 Jun 2014 04:53:56 -0400 Date: Fri, 13 Jun 2014 11:54:17 +0300 From: "Michael S. Tsirkin" Message-ID: <20140613085417.GC2414@redhat.com> References: <20140612074118.GA19354@redhat.com> <20140612075300.GC3720@G08FNSTD100614.fnst.cn.fujitsu.com> <20140613080301.GC2117@redhat.com> <539AB3E4.4090404@redhat.com> <20140613084918.GC28773@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140613084918.GC28773@G08FNSTD100614.fnst.cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hu Tao Cc: Eduardo Habkost , Yasunori Goto , qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini On Fri, Jun 13, 2014 at 04:49:18PM +0800, Hu Tao wrote: > On Fri, Jun 13, 2014 at 10:18:44AM +0200, Paolo Bonzini wrote: > > Il 13/06/2014 10:03, Michael S. Tsirkin ha scritto: > > >>>> > Two points I would like to see addressed before it's going upstream: > > >>>> > - please validate and test the pci branch > > >>>> > there have been lots of changes > > >>>> > - please work to drop the SignedRange: for all > > >>>> > current purposes existing Range is sufficient, > > >>>> > instead of a list and sort re-implementation, it is > > >>>> > better to use g_list_insert_sorted > > >>> > > >>> I see. Thanks for your work! > > >Could you confirm you'll be able to fix these by Monday? > > >I'd like to send the pull request then. > > > > I think SignedRange can be dealt with after the merge. > > > > Paolo > > I agree. Using existing Range makes string output visitor don't support > negative values which it does support before SignedRange. Are there any users though? I think it's more a bug than a feature. Also we do want to get rid of rewriting g_list_insert_sorted though, that's for sure. > Besides SignedRange, tests show that there are several problems with the > pci tree(core dumps, unexpecting exit of qemu). > > Hu OK pls share this info, also pls bisect if possible. Thanks! -- MST