From: Amit Shah <amit.shah@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Juan Quintela" <quintela@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed
Date: Fri, 13 Jun 2014 18:05:40 +0530 [thread overview]
Message-ID: <20140613123540.GC1071@grmbl.mre> (raw)
In-Reply-To: <20140610144329.GH17594@otherpad.lan.raisama.net>
On (Tue) 10 Jun 2014 [11:43:29], Eduardo Habkost wrote:
> On Tue, Jun 10, 2014 at 12:42:14PM +0530, Amit Shah wrote:
> > On (Wed) 14 May 2014 [16:30:09], Eduardo Habkost wrote:
> > > From: Marcelo Tosatti <mtosatti@redhat.com>
> > >
> > > Invariant TSC documentation mentions that "invariant TSC will run at a
> > > constant rate in all ACPI P-, C-. and T-states".
> > >
> > > This is not the case if migration to a host with different TSC frequency
> > > is allowed, or if savevm is performed. So block migration/savevm.
> >
> > Can you add this to the release notes, please?
>
> It can be mentioned as new feature, sure, but note that it shouldn't
> affect any existing users, except the ones who decide to explicitly use
> "-cpu ...,+invtsc" or "-cpu host,migratable=no" on the command line.
Ah, yes; won't break anything. Just that a relnote would be good for
the new functionality being added.
Amit
next prev parent reply other threads:[~2014-06-13 12:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 19:29 [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 02/18] target-i386: Simplify reporting of unavailable features Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 03/18] target-i386: Merge feature filtering/checking functions Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 04/18] target-i386: Pass FeatureWord argument to report_unavailable_features() Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 06/18] target-i386: Make TCG feature filtering more readable Eduardo Habkost
2014-05-14 19:29 ` [Qemu-devel] [PATCH RESEND v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 08/18] target-i386: Filter KVM and 0xC0000001 features on TCG Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 09/18] target-i386: Define TCG_*_FEATURES earlier on cpu.c Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 11/18] target-i386: Loop-based feature word filtering in TCG mode Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 12/18] target-i386: Support check/enforce flags in TCG mode, too Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 13/18] target-i386: Support "-cpu host" in TCG mode Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 14/18] target-i386: Add "migratable" property to "host" CPU model Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 15/18] target-i386: Set migratable=yes by default Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status Eduardo Habkost
2014-05-15 12:14 ` Juan Quintela
2014-05-15 13:08 ` Andreas Färber
2014-05-15 14:05 ` Juan Quintela
2014-05-15 14:15 ` Eduardo Habkost
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed Eduardo Habkost
2014-05-15 12:17 ` Juan Quintela
2014-05-16 9:31 ` Marcelo Tosatti
2014-06-10 7:12 ` Amit Shah
2014-06-10 14:43 ` Eduardo Habkost
2014-06-13 12:35 ` Amit Shah [this message]
2014-05-14 19:30 ` [Qemu-devel] [PATCH RESEND v4 18/18] target-i386: support "invariant tsc" flag Eduardo Habkost
2014-05-14 20:44 ` [Qemu-devel] [PATCH RESEND v4 00/18] target-i386: CPU feature flag queue Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140613123540.GC1071@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).