From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvQiG-0000wy-Ov for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:36:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WvQi9-0001Db-9T for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:36:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WvQi9-0001DP-1h for qemu-devel@nongnu.org; Fri, 13 Jun 2014 08:36:01 -0400 Date: Fri, 13 Jun 2014 18:05:40 +0530 From: Amit Shah Message-ID: <20140613123540.GC1071@grmbl.mre> References: <1400095810-27684-1-git-send-email-ehabkost@redhat.com> <1400095810-27684-18-git-send-email-ehabkost@redhat.com> <20140610071214.GH27148@grmbl.mre> <20140610144329.GH17594@otherpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140610144329.GH17594@otherpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Juan Quintela , Marcelo Tosatti , qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= On (Tue) 10 Jun 2014 [11:43:29], Eduardo Habkost wrote: > On Tue, Jun 10, 2014 at 12:42:14PM +0530, Amit Shah wrote: > > On (Wed) 14 May 2014 [16:30:09], Eduardo Habkost wrote: > > > From: Marcelo Tosatti > > > > > > Invariant TSC documentation mentions that "invariant TSC will run at a > > > constant rate in all ACPI P-, C-. and T-states". > > > > > > This is not the case if migration to a host with different TSC frequency > > > is allowed, or if savevm is performed. So block migration/savevm. > > > > Can you add this to the release notes, please? > > It can be mentioned as new feature, sure, but note that it shouldn't > affect any existing users, except the ones who decide to explicitly use > "-cpu ...,+invtsc" or "-cpu host,migratable=no" on the command line. Ah, yes; won't break anything. Just that a relnote would be good for the new functionality being added. Amit