* [Qemu-devel] [PATCH] vnc: fix screen updates
@ 2014-06-13 8:25 Gerd Hoffmann
2014-06-13 13:00 ` Anthony PERARD
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2014-06-13 8:25 UTC (permalink / raw)
To: qemu-devel; +Cc: anthony.perard, Gerd Hoffmann, Anthony Liguori
Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380.
vnc_jobs_join call is missing in one code path.
Reported-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/vnc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index 6c9d4f3..aac93f0 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -935,6 +935,9 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
}
vnc_job_push(job);
+ if (sync) {
+ vnc_jobs_join(vs);
+ }
vs->force_update = 0;
return n;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] vnc: fix screen updates
2014-06-13 8:25 [Qemu-devel] [PATCH] vnc: fix screen updates Gerd Hoffmann
@ 2014-06-13 13:00 ` Anthony PERARD
0 siblings, 0 replies; 2+ messages in thread
From: Anthony PERARD @ 2014-06-13 13:00 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel, Anthony Liguori
On Fri, Jun 13, 2014 at 10:25:23AM +0200, Gerd Hoffmann wrote:
> Bug was added by 38ee14f4f33f8836fc0e209ca59c6ae8c6edf380.
> vnc_jobs_join call is missing in one code path.
>
> Reported-by: Anthony PERARD <anthony.perard@citrix.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
I've tested the patch, it works.
Thanks!
> ---
> ui/vnc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 6c9d4f3..aac93f0 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -935,6 +935,9 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
> }
>
> vnc_job_push(job);
> + if (sync) {
> + vnc_jobs_join(vs);
> + }
> vs->force_update = 0;
> return n;
> }
--
Anthony PERARD
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-13 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-13 8:25 [Qemu-devel] [PATCH] vnc: fix screen updates Gerd Hoffmann
2014-06-13 13:00 ` Anthony PERARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).