From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwSy0-0008F0-4E for qemu-devel@nongnu.org; Mon, 16 Jun 2014 05:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwSxh-0001XP-QK for qemu-devel@nongnu.org; Mon, 16 Jun 2014 05:12:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwSxh-0001Wp-ID for qemu-devel@nongnu.org; Mon, 16 Jun 2014 05:12:21 -0400 Date: Mon, 16 Jun 2014 17:12:28 +0800 From: Fam Zheng Message-ID: <20140616091227.GF1943@T430.nay.redhat.com> References: <1402865252-25671-1-git-send-email-sbruno@freebsd.org> <1402865252-25671-2-git-send-email-sbruno@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/3 v2] bsd-user: Revert part of update to rules.mk List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sean Bruno , Peter Maydell Cc: Paolo Bonzini , QEMU Developers On Mon, 06/16 08:36, Peter Maydell wrote: > On 15 June 2014 21:47, Sean Bruno wrote: > > In c5cb1afc4675bf5ff66e7a149d2a8cffba2eaa9e rules.mk change was causing > > complete failure on bsd-user when not using --disable-curl > > > > Signed-off-by: Sean Bruno > > --- > > rules.mak | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/rules.mak b/rules.mak > > index dde8e00..4a33c27 100644 > > --- a/rules.mak > > +++ b/rules.mak > > @@ -22,7 +22,8 @@ QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d > > # Same as -I$(SRC_PATH) -I., but for the nested source/object directories > > QEMU_INCLUDES += -I$( > > > -extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs)))) > > +extract-libs = $(strip $(sort $(foreach o,$1,$($o-libs))) \ > > + $(foreach o,$(call expand-objs,$1),$($o-libs))) > > expand-objs = $(strip $(sort $(filter %.o,$1)) \ > > $(foreach o,$(filter %.mo,$1),$($o-objs)) \ > > $(filter-out %.o %.mo,$1)) > > Fam, Paolo: looks like this extract-libs rune is stil causing > problems :-( Sean, could you show the configure command line? Thanks, Fam