From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwnwm-00030Z-36 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 03:36:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwnwf-0004Qc-Q3 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 03:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwnwf-0004Q1-HC for qemu-devel@nongnu.org; Tue, 17 Jun 2014 03:36:41 -0400 Date: Tue, 17 Jun 2014 15:36:31 +0800 From: Stefan Hajnoczi Message-ID: <20140617073631.GL16768@stefanha-thinkpad.redhat.com> References: <20140613111703.22108.14322.stgit@bahia.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OGLMwEELQbPC02lM" Content-Disposition: inline In-Reply-To: <20140613111703.22108.14322.stgit@bahia.local> Subject: Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Kevin Wolf , Peter Maydell , "Michael S. Tsirkin" , Rusty Russell , qemu-devel@nongnu.org, Alexander Graf , Juan Quintela , aneesh.kumar@linux.vnet.ibm.com, Anthony Liguori , Amit Shah , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= --OGLMwEELQbPC02lM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote: > This version merges the changes requested during the v7 review, remarks f= rom > ppc64 dump support review (yes, we talked about virtio there) and the wor= k on > virtio subsections migration. Also two new patches have been added: > - patch #1 is a preliminary fix for virtio-serial posted by Alexander Graf > - patch #9 prepares the work on the virtio_is_big_endian() helper >=20 > The most significant changes are: > - introduction of a new CPU method for virtio > - endianness is taken from CPU that resets the device > - fastpath virtio memory accessors for fixed endian targets > - VMState based virtio subsections (compatibility friendly) I'm surprised it's not enough for the virtio device to have an endianness field (big/little). It seems these patches make endianness depend on the CPUState through which the device is being accessed. Can you explain why it's necessary to check the CPUState? Stefan --OGLMwEELQbPC02lM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTn+//AAoJEJykq7OBq3PIrRwH/AsCWlPk+JKtFYMEpdboClvs VXgw0tC91jOs3xvucmblYbf42uiHY9MXEi6pjt/nvyPOKyrYIoQJRVzpRZscY0/x 1SQ6X3rGbaN3wQOyO79VWqQFn2DSGILhpVUQFAWUBAZ9/V/nXnRS9gvZfpV0IDrJ Rtjged4ComiaojNOo9u+LOOJ7hSw1SeuRY8ideztI/NJARBicUAwT86ojQOWaxei G8Z4YXevm6aacex9UiRPb0jKZ2Zjjsmf693Fffo7XPjwdJ37mnShsY75PIQXzX+t K9Q9eqMkqCkkwlS0/d5Z2w8RXi0DpRZnByMUxoAah6N19hJA8tr4ycJkUO9i3Ic= =Gwik -----END PGP SIGNATURE----- --OGLMwEELQbPC02lM--