qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/4] fixes for pci tree, v2
Date: Tue, 17 Jun 2014 13:55:20 +0300	[thread overview]
Message-ID: <20140617105520.GB6991@redhat.com> (raw)
In-Reply-To: <20140617084753.GA30206@G08FNSTD100614.fnst.cn.fujitsu.com>

On Tue, Jun 17, 2014 at 04:47:53PM +0800, Hu Tao wrote:
> On Mon, Jun 16, 2014 at 02:09:33PM +0300, Michael S. Tsirkin wrote:
> > On Mon, Jun 16, 2014 at 06:05:40PM +0800, Hu Tao wrote:
> > > Michael,
> > > 
> > > This is fixes for your pci tree v2. please review. thanks!
> > 
> > Patches 1,4 applied. Thanks!
> 
> What about patches 2,3? If you need I can resend patch 2 based on Igor's
> comments.   About patch 3, I assume you leave it as it is not a
> regression.

Patch 2 isn't a regression either, right?
Please go ahead and repost patches 2,3 addressing
comments.
They are unrelated so don't have to be in a series, even.

> > 
> > > changes to v1:
> > > 
> > >   1. adds the missing query-memdev and change into querying qom for memdevs(patch 1)
> > >   2. tweak error message (patch 2)
> > >   3. improve error handling for memory-backend-file (patch 3)
> > >   4. fixup the problem that nodes not start from 0 (patch 4)
> > > 
> > > Hu Tao (4):
> > >   qmp: add query-memdev
> > >   check if we have space left for hotplugged memory
> > >   memory-backend-file: improve error handling
> > >   fixup! numa: add -numa node,memdev= option
> > > 
> > >  exec.c           | 26 ++++++++++++-----
> > >  hw/mem/pc-dimm.c |  7 +++++
> > >  numa.c           | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > >  qapi-schema.json | 40 +++++++++++++++++++++++++
> > >  qmp-commands.hx  | 38 ++++++++++++++++++++++++
> > >  5 files changed, 191 insertions(+), 9 deletions(-)
> > > 
> > > -- 
> > > 1.9.3

      reply	other threads:[~2014-06-17 10:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 10:05 [Qemu-devel] [PATCH v2 0/4] fixes for pci tree, v2 Hu Tao
2014-06-16 10:05 ` [Qemu-devel] [PATCH v2 1/4] qmp: add query-memdev Hu Tao
2014-06-16 17:38   ` Eric Blake
2014-06-16 10:05 ` [Qemu-devel] [PATCH v2 2/4] check if we have space left for hotplugged memory Hu Tao
2014-06-16 10:44   ` Igor Mammedov
2014-06-16 10:47   ` Igor Mammedov
2014-06-16 10:05 ` [Qemu-devel] [PATCH v2 3/4] memory-backend-file: improve error handling Hu Tao
2014-06-17 10:03   ` Igor Mammedov
2014-06-17 10:09     ` Hu Tao
2014-06-17 10:56       ` Michael S. Tsirkin
2014-06-16 10:05 ` [Qemu-devel] [PATCH v2 4/4] fixup! numa: add -numa node, memdev= option Hu Tao
2014-06-16 11:09 ` [Qemu-devel] [PATCH v2 0/4] fixes for pci tree, v2 Michael S. Tsirkin
2014-06-17  8:47   ` Hu Tao
2014-06-17 10:55     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140617105520.GB6991@redhat.com \
    --to=mst@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).