From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwsuO-0004MK-97 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwsuE-0005uS-Ct for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:54:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwsuE-0005u5-3k for qemu-devel@nongnu.org; Tue, 17 Jun 2014 08:54:30 -0400 Date: Tue, 17 Jun 2014 20:54:23 +0800 From: Amos Kong Message-ID: <20140617125423.GG8709@z.redhat.com> References: <1402065233-31894-1-git-send-email-akong@redhat.com> <20140609132251.GC19546@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline In-Reply-To: <20140609132251.GC19546@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: afaerber@suse.de, Stefan Hajnoczi Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: > On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: > > It's worth to add a hotplug test to qtest, but without > > cooperation of guest OS, new devices can't be initialized > > by guest, and hot-unplug doesn't work. > >=20 > > However, the new test can cover some part of code of > > hotplug/unplug. > >=20 > > I will write another subtest to test hotplug with pci support. > >=20 > > V2: move qmp_exec_hmp_cmd() to libqtest.c > > excape hmp cmd (stefanha) > > use qmp_exec_hmp_cmd() in blockdev-test > > V3: use vp_list to format string, free escaped string > > V4: free escaped string by g_free() Hi Andreas, Can you apply this patchset to your tree? > > Amos Kong (4): > > virtio-blk-test.c: change pci_nop() to virtblk_init() > > qtest: introduce qmp_exec_hmp_cmd() > > virtio-blk-test.c: add hotplug subtest > > qtest: use qmp_exec_hmp_cmd() in blockdev-test > >=20 > > tests/blockdev-test.c | 23 ++--------------------- > > tests/libqtest.c | 26 ++++++++++++++++++++++++++ > > tests/libqtest.h | 9 +++++++++ > > tests/virtio-blk-test.c | 44 +++++++++++++++++++++++++++++++++++++----= --- > > 4 files changed, 74 insertions(+), 28 deletions(-) > >=20 > > --=20 > > 1.9.3 > >=20 >=20 > Reviewed-by: Stefan Hajnoczi --=20 Amos. --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJToDp/AAoJELxSv6I5vP9jbu0P/RsMwPFfp1x3XAK1FvQwUKn9 9vK+d6NA9Vvgm6nBRESgMO4NSgAEzv2JpGrCLm5zbrg/RDwsizgy2ume0bTkUXyo vk6bU+6c/ymvE+iyEjC+so5TrT7KhfNJvQGqNgbbpBy5GjFiqqyWNBgJdTRQrGku j/nrTUP6fSDeH+WIYF7ehZAlEmIybUakNIdDWddrIMN6bR6c2eP68/sH0smOEUN7 EoQrgImuaDn9NaGbGMkJ8EZwUB6bZD8X5sdSRDiyTOu/R3pl7QGirXpa4fYlpwfM 4krMmHUESdIsxUHlxnc0AKJaSNR2dSL5zvdPgfIawu65WtXmmedVG64WXkHEBxbt kLDgDD7gL4TqUtxvGlnWwXf/QkhJcW+8lf2D9+1gV5kGfVpFjEcMIRPDvdnVUXdw E8+FLBPPn5jBvRmbuwWML7p7c5b+F5mMWDBAWwpZxz4DktCWMq52Pc+oOc2mMpTy pgKBC5bKV4X5IhISPpuiAJnIhfv/MXG2QDn7cmAtOu6/myWbRPFd9avrd6f1IdmM zUitDT2mFBoAWwrRl869ZH4S1a5ANO5AfxXweCLekdNzu3M3mpFRV0/E23i0yR7r FATpwC6ErDxzS8g4KvCYiaGP43DJoDCB+WPDtAVgO4l7bAuIqPlO5ebCPPhulMm2 9FqWloI1jP56Vf0zvT+o =YdLb -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM--