From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwyHT-0005HT-4H for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:39:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WwyHE-0000cE-4W for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:38:51 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:48683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WwyHD-0000bT-W9 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:38:36 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Jun 2014 14:38:35 -0400 Date: Tue, 17 Jun 2014 11:38:16 -0700 From: Nishanth Aravamudan Message-ID: <20140617183815.GQ16644@linux.vnet.ibm.com> References: <1402905233-26510-1-git-send-email-aik@ozlabs.ru> <539EA7DD.8040306@ozlabs.ru> <20140616205150.GD8629@otherpad.lan.raisama.net> <539FD767.2020905@ozlabs.ru> <20140617140700.GG3222@otherpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140617140700.GG3222@otherpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH 0/7] spapr: rework memory nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On 17.06.2014 [11:07:00 -0300], Eduardo Habkost wrote: > > If it is canonical and kosher way of using NUMA in QEMU, ok, we can use it. > > I just fail to see why we need a requirement for nodes to go consequently > > here. And it confuses me as a user a bit if I can add "-numa > > node,nodeid=22" (no memory, no cpus) but do not get to see it in the guest. > > I agree with you it is confusing. But before we support that use case, > we need to make sure auto-allocation is handled properly, because it > would be hard to fix it later without breaking compatibility. > > We probably just need a "present" field on struct NodeInfo, so > machine-specific code and auto-allocation code can differentiate nodes > that are not present on the command-line from empty nodes that were > specified in the command-line. What/where is struct NodeInfo? Thanks, Nish