From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WwyL9-0001nd-Ai
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WwyL4-0002CD-5d
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37008)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WwyL3-0002C9-TJ
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 14:42:34 -0400
Date: Tue, 17 Jun 2014 21:42:57 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140617184257.GB15610@redhat.com>
References: <1403021756-15960-1-git-send-email-mst@redhat.com>
	<1403021756-15960-12-git-send-email-mst@redhat.com>
	<53A08B64.4050605@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53A08B64.4050605@redhat.com>
Subject: Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set
	already used memdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>, Anthony Liguori <aliguori@amazon.com>, Peter Crosthwaite <peter.crostwaite@xilinx.com>, Igor Mammedov <imammedo@redhat.com>

On Tue, Jun 17, 2014 at 12:39:32PM -0600, Eric Blake wrote:
> On 06/17/2014 11:36 AM, Michael S. Tsirkin wrote:
> > From: Igor Mammedov <imammedo@redhat.com>
> > 
> > using the same memdev backend more than once will cause
> > assersion at MemoryRegion mapping time becase it's already
> 
> s/assersion/assertion/; s/becase/because/
> (but probably too late now that this is a pull request)

Absolutely too late.
I don't mind spelling errors in commit logs too much, they
don't show up in code. If noted in time I fix them in place ...

> > mapped. Prevent it by checking that associated MemoryRegion
> > is not mapped.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Acked-by: Peter Crosthwaite <peter.crostwaite@xilinx.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>