From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wwyjj-00012j-Gx
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 15:08:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wwyje-0003IX-Ta
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 15:08:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63781)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wwyje-0003II-LX
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 15:07:58 -0400
Date: Tue, 17 Jun 2014 22:08:11 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140617190811.GE15610@redhat.com>
References: <1403021756-15960-1-git-send-email-mst@redhat.com>
	<1403021756-15960-14-git-send-email-mst@redhat.com>
	<53A08C07.1050704@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53A08C07.1050704@redhat.com>
Subject: Re: [Qemu-devel] [PULL 013/103] pc: exit QEMU if number of slots
 more than supported 256
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Alex Bligh <alex@alex.org.uk>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Peter Crosthwaite <peter.crostwaite@xilinx.com>, Igor Mammedov <imammedo@redhat.com>, Anthony Liguori <aliguori@amazon.com>

On Tue, Jun 17, 2014 at 12:42:15PM -0600, Eric Blake wrote:
> On 06/17/2014 11:37 AM, Michael S. Tsirkin wrote:
> > From: Igor Mammedov <imammedo@redhat.com>
> > 
> > ... which is imposed by current naming scheme of ACPI memory devices.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Acked-by: Peter Crosthwaite <peter.crostwaite@xilinx.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> 
> > +/*
> > + * current device naming scheme supports
> > + * only upto 256 memory devices
> 
> s/upto/up to/ (while English has several compound words such as "into"
> or "onto", it does not have an "upto").
> 
> Probably too late for this pull request, but something you could clean
> up as a followup

Fixed in a patch on top.

> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>