From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wx1Nl-0008Sl-VP
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 17:57:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wx1Nf-0002n5-HF
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 17:57:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1Wx1Nf-0002n0-87
	for qemu-devel@nongnu.org; Tue, 17 Jun 2014 17:57:27 -0400
Date: Tue, 17 Jun 2014 17:57:22 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20140617215722.GA6924@localhost.localdomain>
References: <cover.1402683788.git.jcody@redhat.com>
	<53A03241.8090106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53A03241.8090106@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 00/10] Modify block jobs to use
	node-names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, benoit.canet@irqsave.net, pkrempa@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, Jun 17, 2014 at 06:19:13AM -0600, Eric Blake wrote:
> On 06/13/2014 12:52 PM, Jeff Cody wrote:
> > Changes from v4->v5:
> > 
> > * Rebased on master
> > * Fixed commit log typos / stale paragraphs (Eric)
> > * Fixed comment typo (Eric)
> > * Added Eric's remaining R-b's
> > 
> 
> On IRC, we found another bug that needs repairing:
> 
> # cd /tmp
> # echo tmp > tmp
> # qemu-kvm -qmp stdio -drive file=/tmp/tmp
> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 2},
> "package": ""}, "capabilities": []}}
> {"execute":"qmp_capabilities"}
> {"return": {}}
> {"execute":"block-commit","arguments":{"device":"ide0-hd0"}}
> {"return": {}}
> {"timestamp": {"seconds": 1402972048, "microseconds": 153175}, "event":
> "BLOCK_JOB_READY", "data": {"device": "ide0-hd0", "len": 512, "offset":
> 512, "speed": 0, "type": "commit"}}
> {"execute":"block-job-complete","arguments":{"device":"ide0-hd0"}}
> {"return": {}}
> qemu-system-x86_64: block.c:2034: bdrv_swap: Assertion
> `bs_new->device_name[0] == '\0'' failed.
> Aborted (core dumped)
> 
> Attempts to commit-to-self should be rejected at block-commit time,
> rather than causing an assertion failure down the road.
> 

I put the changes to fix this in patch 4/10 in the v6 (along with the
additional comment).  I mean to drop your R-b in the patch so you
could review it again, but I forgot before sending it (sorry) - but if
you want to review it, it is all contained in patch 4.

Jeff