From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx65a-0002Lz-S2 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 22:59:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wx65U-0006vN-NE for qemu-devel@nongnu.org; Tue, 17 Jun 2014 22:59:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wx65U-0006vJ-Eq for qemu-devel@nongnu.org; Tue, 17 Jun 2014 22:59:00 -0400 Date: Wed, 18 Jun 2014 10:58:52 +0800 From: Amos Kong Message-ID: <20140618025852.GA32372@z.redhat.com> References: <1402065233-31894-1-git-send-email-akong@redhat.com> <20140609132251.GC19546@stefanha-thinkpad.redhat.com> <20140617125423.GG8709@z.redhat.com> <53A04484.7030702@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <53A04484.7030702@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 0/4] test virtio-blk hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Stefan Hajnoczi , arei.gonglei@huawei.com, qemu-devel@nongnu.org On Tue, Jun 17, 2014 at 03:37:08PM +0200, Andreas F=E4rber wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Hi Amos, >=20 > Am 17.06.2014 14:54, schrieb Amos Kong: > > On Mon, Jun 09, 2014 at 03:22:51PM +0200, Stefan Hajnoczi wrote: > >> On Fri, Jun 06, 2014 at 10:33:49PM +0800, Amos Kong wrote: > >>> It's worth to add a hotplug test to qtest, but without=20 > >>> cooperation of guest OS, new devices can't be initialized by > >>> guest, and hot-unplug doesn't work. > >>>=20 > >>> However, the new test can cover some part of code of=20 > >>> hotplug/unplug. > >>>=20 > >>> I will write another subtest to test hotplug with pci support. > >>>=20 > >>> V2: move qmp_exec_hmp_cmd() to libqtest.c excape hmp cmd > >>> (stefanha) use qmp_exec_hmp_cmd() in blockdev-test V3: use > >>> vp_list to format string, free escaped string V4: free escaped > >>> string by g_free() > >=20 > > Hi Andreas, > >=20 > > Can you apply this patchset to your tree? >=20 > Sorry for the late reply, I was on vacation and am still fighting a > mail backlog... That's OK :) =20 > I had a question about the new HMP helper function - I see in 4/4 that > drive_add was already being done via HMP, so I guess that's the > culprit, but still I wonder whether we can do device-add via QMP. I didn't find device_add/del definition in qapi-schema.json, so I used HMP instead. Actually those two QMP commands exist and work. { "execute": "blockdev-add", "arguments": { "options": { "driver": "file", "filename": "/dev/null", "id": "id1" } } } { "execute": "device_add", "arguments": { "driver": "virtio-blk-pci", "drive": "id1", "driver": "virtio-blk-pci", "id": "id2" } } I will convert virtio-blk-test to use QMP, send a V5. =20 > That said, I've reviewed the generic qtest part OK, and would assume > virtio-blk-test (you can drop the .c in the topic please) to go > through the same tree virtio-blk does, so via Stefan/Kevin. Stefan said (offline) it belongs to you, and I found the first commit of this file was merged by you. =20 Thanks. > Regards, > Andreas --=20 Amos.