qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] qemu-img segfault on latest git
@ 2014-06-17 15:08 Milos Vyletel
  2014-06-18  2:58 ` Chun Yan Liu
  2014-06-18 10:02 ` Stefan Hajnoczi
  0 siblings, 2 replies; 4+ messages in thread
From: Milos Vyletel @ 2014-06-17 15:08 UTC (permalink / raw)
  To: qemu-devel; +Cc: Milos Vyletel

Hi,

I hope this is the right place to report this. I've noticed that I
can't run qemu-img convert on latest git version because it segfaults.
I've bisected the code and identified that this was caused by

commit 6f482f742dd841b45297fb0e5f3d2c81779253be
Author: Chunyan Liu <cyliu@suse.com>
Date:   Thu Jun 5 17:21:01 2014 +0800

    raw-posix.c: replace QEMUOptionParameter with QemuOpts

    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
    Signed-off-by: Chunyan Liu <cyliu@suse.com>
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

bisect log:
git bisect start
# bad: [af44da87e926ff64260b95f4350d338c4fc113ca] Merge
remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream'
into staging
git bisect bad af44da87e926ff64260b95f4350d338c4fc113ca
# good: [10f08a0a3435afea441db8d0981dbad49042c7cf] qemu-iotests: Test
converting to streamOptimized from small cluster size
git bisect good 10f08a0a3435afea441db8d0981dbad49042c7cf
# good: [1673e89e93e08cbfee7c9b552008e5b39469ad0e] Merge
remote-tracking branch 'remotes/kraxel/tags/pull-sdl-3' into staging
git bisect good 1673e89e93e08cbfee7c9b552008e5b39469ad0e
# good: [a491af471bf8f1188b2665f54d109065d4591e45] json-parser: drop
superfluous assignment for token variable
git bisect good a491af471bf8f1188b2665f54d109065d4591e45
# good: [10582ff832798813ba3a17f13f3ab46250388b47] spapr: Add ibm,
chip-id property in device tree
git bisect good 10582ff832798813ba3a17f13f3ab46250388b47
# good: [6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae] target-ppc: Make
use of gen_spr_book3s_altivec() for POWER7/8
git bisect good 6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae
# bad: [bd0cf596fd1200d162e5655adff9c06d40dbdd14] rbd.c: replace
QEMUOptionParameter with QemuOpts
git bisect bad bd0cf596fd1200d162e5655adff9c06d40dbdd14
# good: [8559e45e51edd22dd48d54cce8b0521e6339f3e9] QemuOpts: add
conversion between QEMUOptionParameter to QemuOpts
git bisect good 8559e45e51edd22dd48d54cce8b0521e6339f3e9
# good: [98c10b810a83a0f52b4b5a14a8a36ce0622cb01f] nfs.c: replace
QEMUOptionParameter with QemuOpts
git bisect good 98c10b810a83a0f52b4b5a14a8a36ce0622cb01f
# good: [7ab74849a5724452b35982a6e7d658c25839f5e5] qed.c: replace
QEMUOptionParameter with QemuOpts
git bisect good 7ab74849a5724452b35982a6e7d658c25839f5e5
# bad: [ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a] raw-win32.c: replace
QEMUOptionParameter with QemuOpts
git bisect bad ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a
# bad: [6f482f742dd841b45297fb0e5f3d2c81779253be] raw-posix.c: replace
QEMUOptionParameter with QemuOpts
git bisect bad 6f482f742dd841b45297fb0e5f3d2c81779253be

test script:
#!/bin/bash

make -j 24 clean
./configure
make -j 24 qemu-img

./qemu-img create -f raw ~/qemu-test.img 128M

./qemu-img convert -p -f raw ~/qemu-test.img -O vmdk \
    -o adapter_type=lsilogic,subformat=streamOptimized,compat6 \
    ~/qemu-test.vmdk

[ -f ~/qemu-test.vmdk ] && ret=0 || ret=1

rm -f ~/qemu-test.{img,vmdk}

exit $ret

Milos

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Qemu-devel] qemu-img segfault on latest git
  2014-06-17 15:08 [Qemu-devel] qemu-img segfault on latest git Milos Vyletel
@ 2014-06-18  2:58 ` Chun Yan Liu
  2014-06-18 10:02 ` Stefan Hajnoczi
  1 sibling, 0 replies; 4+ messages in thread
From: Chun Yan Liu @ 2014-06-18  2:58 UTC (permalink / raw)
  To: Milos Vyletel, qemu-devel

Fixed by adding NULL opts check in qemu_opt_get functions.
Patch is here:
http://comments.gmane.org/gmane.comp.emulators.qemu/280916

Regards,
Chunyan

>>> On 6/17/2014 at 11:08 PM, in message
<CAAFXRd1u6xb2JM9Kt_DXeHavGxWEYitbnnJvp=OkQkwz9Da6gw@mail.gmail.com>, Milos
Vyletel <milos.vyletel@gmail.com> wrote: 
> Hi, 
>  
> I hope this is the right place to report this. I've noticed that I 
> can't run qemu-img convert on latest git version because it segfaults. 
> I've bisected the code and identified that this was caused by 
>  
> commit 6f482f742dd841b45297fb0e5f3d2c81779253be 
> Author: Chunyan Liu <cyliu@suse.com> 
> Date:   Thu Jun 5 17:21:01 2014 +0800 
>  
>     raw-posix.c: replace QEMUOptionParameter with QemuOpts 
>  
>     Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> 
>     Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com> 
>     Signed-off-by: Chunyan Liu <cyliu@suse.com> 
>     Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> 
>  
> bisect log: 
> git bisect start 
> # bad: [af44da87e926ff64260b95f4350d338c4fc113ca] Merge 
> remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' 
> into staging 
> git bisect bad af44da87e926ff64260b95f4350d338c4fc113ca 
> # good: [10f08a0a3435afea441db8d0981dbad49042c7cf] qemu-iotests: Test 
> converting to streamOptimized from small cluster size 
> git bisect good 10f08a0a3435afea441db8d0981dbad49042c7cf 
> # good: [1673e89e93e08cbfee7c9b552008e5b39469ad0e] Merge 
> remote-tracking branch 'remotes/kraxel/tags/pull-sdl-3' into staging 
> git bisect good 1673e89e93e08cbfee7c9b552008e5b39469ad0e 
> # good: [a491af471bf8f1188b2665f54d109065d4591e45] json-parser: drop 
> superfluous assignment for token variable 
> git bisect good a491af471bf8f1188b2665f54d109065d4591e45 
> # good: [10582ff832798813ba3a17f13f3ab46250388b47] spapr: Add ibm, 
> chip-id property in device tree 
> git bisect good 10582ff832798813ba3a17f13f3ab46250388b47 
> # good: [6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae] target-ppc: Make 
> use of gen_spr_book3s_altivec() for POWER7/8 
> git bisect good 6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae 
> # bad: [bd0cf596fd1200d162e5655adff9c06d40dbdd14] rbd.c: replace 
> QEMUOptionParameter with QemuOpts 
> git bisect bad bd0cf596fd1200d162e5655adff9c06d40dbdd14 
> # good: [8559e45e51edd22dd48d54cce8b0521e6339f3e9] QemuOpts: add 
> conversion between QEMUOptionParameter to QemuOpts 
> git bisect good 8559e45e51edd22dd48d54cce8b0521e6339f3e9 
> # good: [98c10b810a83a0f52b4b5a14a8a36ce0622cb01f] nfs.c: replace 
> QEMUOptionParameter with QemuOpts 
> git bisect good 98c10b810a83a0f52b4b5a14a8a36ce0622cb01f 
> # good: [7ab74849a5724452b35982a6e7d658c25839f5e5] qed.c: replace 
> QEMUOptionParameter with QemuOpts 
> git bisect good 7ab74849a5724452b35982a6e7d658c25839f5e5 
> # bad: [ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a] raw-win32.c: replace 
> QEMUOptionParameter with QemuOpts 
> git bisect bad ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a 
> # bad: [6f482f742dd841b45297fb0e5f3d2c81779253be] raw-posix.c: replace 
> QEMUOptionParameter with QemuOpts 
> git bisect bad 6f482f742dd841b45297fb0e5f3d2c81779253be 
>  
> test script: 
> #!/bin/bash 
>  
> make -j 24 clean 
> ./configure 
> make -j 24 qemu-img 
>  
> ./qemu-img create -f raw ~/qemu-test.img 128M 
>  
> ./qemu-img convert -p -f raw ~/qemu-test.img -O vmdk \ 
>     -o adapter_type=lsilogic,subformat=streamOptimized,compat6 \ 
>     ~/qemu-test.vmdk 
>  
> [ -f ~/qemu-test.vmdk ] && ret=0 || ret=1 
>  
> rm -f ~/qemu-test.{img,vmdk} 
>  
> exit $ret 
>  
> Milos 
>  
>  
>  

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Qemu-devel] qemu-img segfault on latest git
  2014-06-17 15:08 [Qemu-devel] qemu-img segfault on latest git Milos Vyletel
  2014-06-18  2:58 ` Chun Yan Liu
@ 2014-06-18 10:02 ` Stefan Hajnoczi
  2014-06-18 23:31   ` Fam Zheng
  1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2014-06-18 10:02 UTC (permalink / raw)
  To: Milos Vyletel; +Cc: Fam Zheng, qemu-devel, Chunyan Liu

[-- Attachment #1: Type: text/plain, Size: 3328 bytes --]

On Tue, Jun 17, 2014 at 11:08:48AM -0400, Milos Vyletel wrote:
> I hope this is the right place to report this. I've noticed that I
> can't run qemu-img convert on latest git version because it segfaults.
> I've bisected the code and identified that this was caused by

Thanks for the bug report!

> commit 6f482f742dd841b45297fb0e5f3d2c81779253be
> Author: Chunyan Liu <cyliu@suse.com>
> Date:   Thu Jun 5 17:21:01 2014 +0800
> 
>     raw-posix.c: replace QEMUOptionParameter with QemuOpts
> 
>     Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>     Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>     Signed-off-by: Chunyan Liu <cyliu@suse.com>
>     Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> bisect log:
> git bisect start
> # bad: [af44da87e926ff64260b95f4350d338c4fc113ca] Merge
> remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream'
> into staging
> git bisect bad af44da87e926ff64260b95f4350d338c4fc113ca
> # good: [10f08a0a3435afea441db8d0981dbad49042c7cf] qemu-iotests: Test
> converting to streamOptimized from small cluster size
> git bisect good 10f08a0a3435afea441db8d0981dbad49042c7cf
> # good: [1673e89e93e08cbfee7c9b552008e5b39469ad0e] Merge
> remote-tracking branch 'remotes/kraxel/tags/pull-sdl-3' into staging
> git bisect good 1673e89e93e08cbfee7c9b552008e5b39469ad0e
> # good: [a491af471bf8f1188b2665f54d109065d4591e45] json-parser: drop
> superfluous assignment for token variable
> git bisect good a491af471bf8f1188b2665f54d109065d4591e45
> # good: [10582ff832798813ba3a17f13f3ab46250388b47] spapr: Add ibm,
> chip-id property in device tree
> git bisect good 10582ff832798813ba3a17f13f3ab46250388b47
> # good: [6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae] target-ppc: Make
> use of gen_spr_book3s_altivec() for POWER7/8
> git bisect good 6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae
> # bad: [bd0cf596fd1200d162e5655adff9c06d40dbdd14] rbd.c: replace
> QEMUOptionParameter with QemuOpts
> git bisect bad bd0cf596fd1200d162e5655adff9c06d40dbdd14
> # good: [8559e45e51edd22dd48d54cce8b0521e6339f3e9] QemuOpts: add
> conversion between QEMUOptionParameter to QemuOpts
> git bisect good 8559e45e51edd22dd48d54cce8b0521e6339f3e9
> # good: [98c10b810a83a0f52b4b5a14a8a36ce0622cb01f] nfs.c: replace
> QEMUOptionParameter with QemuOpts
> git bisect good 98c10b810a83a0f52b4b5a14a8a36ce0622cb01f
> # good: [7ab74849a5724452b35982a6e7d658c25839f5e5] qed.c: replace
> QEMUOptionParameter with QemuOpts
> git bisect good 7ab74849a5724452b35982a6e7d658c25839f5e5
> # bad: [ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a] raw-win32.c: replace
> QEMUOptionParameter with QemuOpts
> git bisect bad ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a
> # bad: [6f482f742dd841b45297fb0e5f3d2c81779253be] raw-posix.c: replace
> QEMUOptionParameter with QemuOpts
> git bisect bad 6f482f742dd841b45297fb0e5f3d2c81779253be
> 
> test script:
> #!/bin/bash
> 
> make -j 24 clean
> ./configure
> make -j 24 qemu-img
> 
> ./qemu-img create -f raw ~/qemu-test.img 128M
> 
> ./qemu-img convert -p -f raw ~/qemu-test.img -O vmdk \
>     -o adapter_type=lsilogic,subformat=streamOptimized,compat6 \
>     ~/qemu-test.vmdk
> 
> [ -f ~/qemu-test.vmdk ] && ret=0 || ret=1
> 
> rm -f ~/qemu-test.{img,vmdk}
> 
> exit $ret
> 
> Milos
> 

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Qemu-devel] qemu-img segfault on latest git
  2014-06-18 10:02 ` Stefan Hajnoczi
@ 2014-06-18 23:31   ` Fam Zheng
  0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-06-18 23:31 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: Chunyan Liu, qemu-devel, Milos Vyletel

On Wed, 06/18 18:02, Stefan Hajnoczi wrote:
> On Tue, Jun 17, 2014 at 11:08:48AM -0400, Milos Vyletel wrote:
> > I hope this is the right place to report this. I've noticed that I
> > can't run qemu-img convert on latest git version because it segfaults.
> > I've bisected the code and identified that this was caused by
> 
> Thanks for the bug report!

Thanks,

Pointer used withoug checking. I will post a patch and Cc you all.

Fam

> 
> > commit 6f482f742dd841b45297fb0e5f3d2c81779253be
> > Author: Chunyan Liu <cyliu@suse.com>
> > Date:   Thu Jun 5 17:21:01 2014 +0800
> > 
> >     raw-posix.c: replace QEMUOptionParameter with QemuOpts
> > 
> >     Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >     Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> >     Signed-off-by: Chunyan Liu <cyliu@suse.com>
> >     Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > bisect log:
> > git bisect start
> > # bad: [af44da87e926ff64260b95f4350d338c4fc113ca] Merge
> > remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream'
> > into staging
> > git bisect bad af44da87e926ff64260b95f4350d338c4fc113ca
> > # good: [10f08a0a3435afea441db8d0981dbad49042c7cf] qemu-iotests: Test
> > converting to streamOptimized from small cluster size
> > git bisect good 10f08a0a3435afea441db8d0981dbad49042c7cf
> > # good: [1673e89e93e08cbfee7c9b552008e5b39469ad0e] Merge
> > remote-tracking branch 'remotes/kraxel/tags/pull-sdl-3' into staging
> > git bisect good 1673e89e93e08cbfee7c9b552008e5b39469ad0e
> > # good: [a491af471bf8f1188b2665f54d109065d4591e45] json-parser: drop
> > superfluous assignment for token variable
> > git bisect good a491af471bf8f1188b2665f54d109065d4591e45
> > # good: [10582ff832798813ba3a17f13f3ab46250388b47] spapr: Add ibm,
> > chip-id property in device tree
> > git bisect good 10582ff832798813ba3a17f13f3ab46250388b47
> > # good: [6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae] target-ppc: Make
> > use of gen_spr_book3s_altivec() for POWER7/8
> > git bisect good 6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae
> > # bad: [bd0cf596fd1200d162e5655adff9c06d40dbdd14] rbd.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad bd0cf596fd1200d162e5655adff9c06d40dbdd14
> > # good: [8559e45e51edd22dd48d54cce8b0521e6339f3e9] QemuOpts: add
> > conversion between QEMUOptionParameter to QemuOpts
> > git bisect good 8559e45e51edd22dd48d54cce8b0521e6339f3e9
> > # good: [98c10b810a83a0f52b4b5a14a8a36ce0622cb01f] nfs.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect good 98c10b810a83a0f52b4b5a14a8a36ce0622cb01f
> > # good: [7ab74849a5724452b35982a6e7d658c25839f5e5] qed.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect good 7ab74849a5724452b35982a6e7d658c25839f5e5
> > # bad: [ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a] raw-win32.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a
> > # bad: [6f482f742dd841b45297fb0e5f3d2c81779253be] raw-posix.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad 6f482f742dd841b45297fb0e5f3d2c81779253be
> > 
> > test script:
> > #!/bin/bash
> > 
> > make -j 24 clean
> > ./configure
> > make -j 24 qemu-img
> > 
> > ./qemu-img create -f raw ~/qemu-test.img 128M
> > 
> > ./qemu-img convert -p -f raw ~/qemu-test.img -O vmdk \
> >     -o adapter_type=lsilogic,subformat=streamOptimized,compat6 \
> >     ~/qemu-test.vmdk
> > 
> > [ -f ~/qemu-test.vmdk ] && ret=0 || ret=1
> > 
> > rm -f ~/qemu-test.{img,vmdk}
> > 
> > exit $ret
> > 
> > Milos
> > 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-18 23:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 15:08 [Qemu-devel] qemu-img segfault on latest git Milos Vyletel
2014-06-18  2:58 ` Chun Yan Liu
2014-06-18 10:02 ` Stefan Hajnoczi
2014-06-18 23:31   ` Fam Zheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).