From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCxk-00018C-G8 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxCxb-0001yF-AC for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:19:28 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:41784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxCxb-0001y8-3q for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:19:19 -0400 Received: by mail-we0-f179.google.com with SMTP id w62so598784wes.24 for ; Wed, 18 Jun 2014 03:19:18 -0700 (PDT) Date: Wed, 18 Jun 2014 18:19:07 +0800 From: Stefan Hajnoczi Message-ID: <20140618101907.GF14030@stefanha-thinkpad.redhat.com> References: <1402939751-8371-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JSkcQAAxhB1h8DcT" Content-Disposition: inline In-Reply-To: <1402939751-8371-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: romain@dolbeau.org, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de --JSkcQAAxhB1h8DcT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: >=20 > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). >=20 > - allow mii_tool on linux access to all the phy registers and flags > it requires in order to report a successfully auto-negotiated link. >=20 > - inject LSC interrupt upon successful link auto-negotiation (required > by stock OS X e1000 driver). >=20 > See additional prose following commit logs in 2/3 (making up excuses > for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows > re. auto-negotiation and LSC injection). >=20 > Thanks much, > Gabriel >=20 > Gabriel L. Somlo (3): > e1000: emulate auto-negotiation during external link status change > e1000: improve auto-negotiation reporting via mii-tool > e1000: signal guest on successful link auto-negotiation >=20 > hw/net/e1000.c | 24 +++++++++++++++++++----- > hw/net/e1000_regs.h | 3 +++ > 2 files changed, 22 insertions(+), 5 deletions(-) =46rom my limited e1000 understanding and some checking against the datasheet: Reviewed-by: Stefan Hajnoczi Since Michael Tsirkin's attention has been drawn, I'll leave this series for him to review and merge. --JSkcQAAxhB1h8DcT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJToWebAAoJEJykq7OBq3PImN0IAKEEtJNO9UFkhWtsIIqTzdqU pvt5RAF6893BLJWimVJ38bhheZO/lw4280bZBc4Cv0gnlM9O2XgHOFa53BXoJHfY N/PQtSIruAsQXkVffgrrkHVCFFNDpgFoMWpClT/UAZ51rQRVNM3ntDDLPugfznhT /J4QNDG4m6xqquq72QdZkJd80DeAaijwLyR3S126eS9pufvkhC1xEuKDHrxGvWqW m9PLe6OgCCC055Ka+tXj/bjBRumJz7seWdJrMLkT+5ETDgGWdH6HZzVgY6vbXpzG Y0SG0BZErVvTyOp/JcaOMg/NMnAwgbz/3qFHz8Kl/nRjo+EGC05dS2AXACC2Ssc= =GM5z -----END PGP SIGNATURE----- --JSkcQAAxhB1h8DcT--