From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxDQP-0004C4-Jd for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxDQK-0004Ka-5o for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:49:05 -0400 Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:48098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxDQJ-0004KS-Uv for qemu-devel@nongnu.org; Wed, 18 Jun 2014 06:49:00 -0400 Received: by mail-we0-f178.google.com with SMTP id x48so632521wes.37 for ; Wed, 18 Jun 2014 03:48:59 -0700 (PDT) Date: Wed, 18 Jun 2014 18:48:49 +0800 From: Stefan Hajnoczi Message-ID: <20140618104849.GH14030@stefanha-thinkpad.redhat.com> References: <87vbs6qjhj.fsf_-_@blackfin.pond.sub.org> <5399CF09.8030803@6wind.com> <87ppidnqmy.fsf@blackfin.pond.sub.org> <539AC3E0.9090404@6wind.com> <539ACDE6.7020709@redhat.com> <539AFF7C.7090702@6wind.com> <539B064D.2050501@redhat.com> <53A00464.8090609@6wind.com> <53A00DEB.8030400@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline In-Reply-To: <53A00DEB.8030400@redhat.com> Subject: Re: [Qemu-devel] Why I advise against using ivshmem List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Henning Schild , Olivier MATZ , kvm , qemu-devel , David Marchand , Linux Virtualization , Vincent JARDIN , "thomas.monjalon@6wind.com" --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2014 at 11:44:11AM +0200, Paolo Bonzini wrote: > Il 17/06/2014 11:03, David Marchand ha scritto: > >>Unless someone steps up and maintains ivshmem, I think it should be > >>deprecated and dropped from QEMU. > > > >Then I can maintain ivshmem for QEMU. > >If this is ok, I will send a patch for MAINTAINERS file. >=20 > Typically, adding yourself to maintainers is done only after having proved > your ability to be a maintainer. :) >=20 > So, let's stop talking and go back to code! You can start doing what was > suggested elsewhere in the thread: get the server and uio driver merged i= nto > the QEMU tree, document the protocol in docs/specs/ivshmem_device_spec.tx= t, > and start fixing bugs such as the ones that Markus reported. One more thing to add to the list: static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) The "flags" argument should be "size". Size should be checked before accessing buf. Please also see the bug fixes in the following unapplied patch: "[PATCH] ivshmem: fix potential OOB r/w access (#2)" by Sebastian Krahmer https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03538.html Stefan --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJToW6RAAoJEJykq7OBq3PI+0wH/iAKhezs5crrEP4LmcyhGwHH pIl1XcppxflzkLonaRnT11scmzXY6ilnw0ajpX2axVTao/YHOR/ii7DRhZGKGuLu jNUS0xk9mgUpfTZ7z4OdXHum8MhLaIF21znbUKPhtpz086+oiwhmMYgOiNW/PXAP LsOLJXON5/NAoP3GzIkhW06Kq7fRUST3ZxqIDVvoNCBYEEd8/qGD234rxyAk9u7P Fo3j+KJ1h+RwOeu4A+lQCsP//45L6EWfhmdVKlPD3/98F8/7gfQkCxEozAeKmoYL 3UJFzioZZjE22GrLA59vgXtCqGm0HnYzX3ebAqEtlM/ORi3RLA+L1pXCDg8hpgs= =bsS6 -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE--