From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] hw/block/pflash_cfi01: Report correct size info for parallel configs
Date: Wed, 18 Jun 2014 18:52:13 +0800 [thread overview]
Message-ID: <20140618105213.GJ14030@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CAFEAcA-HqQRXvkYD4piEk_2LqNxaR7P1f=wBz6nv01Nvct1BaA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
On Mon, Jun 16, 2014 at 11:52:22AM +0100, Peter Maydell wrote:
> On 10 June 2014 15:03, Peter Maydell <peter.maydell@linaro.org> wrote:
> > If the flash device is configured with a device-width which is
> > not equal to the bank-width, indicating that it is actually several
> > narrow flash devices in parallel, the CFI table should report the
> > number of blocks and the size of a single device, not of the whole
> > combined setup. This stops Linux from complaining:
> > "NOR chip too large to fit in mapping. Attempting to cope..."
> >
> > As usual, we retain the old broken but backwards compatible behaviour
> > when the device-width is not specified.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > At the moment vexpress is the only board which properly sets device-width
> > rather than using the back-compat misemulated behaviour...
>
> Kevin, Stefan: since this only affects ARM boards at
> the moment, I'll put this in via target-arm.next unless
> you particularly want to put it in through the block queue.
That's fine.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-06-18 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 14:03 [Qemu-devel] [PATCH] hw/block/pflash_cfi01: Report correct size info for parallel configs Peter Maydell
2014-06-13 23:27 ` Peter Crosthwaite
2014-06-16 10:52 ` Peter Maydell
2014-06-18 10:52 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618105213.GJ14030@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).