From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WxPK5-0004ir-H6
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WxPJw-00023B-Ql
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11732)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WxPJw-000237-IS
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 19:31:12 -0400
Date: Thu, 19 Jun 2014 07:31:27 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140618233127.GA23720@T430.redhat.com>
References: <CAAFXRd1u6xb2JM9Kt_DXeHavGxWEYitbnnJvp=OkQkwz9Da6gw@mail.gmail.com>
	<20140618100220.GD14030@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140618100220.GD14030@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] qemu-img segfault on latest git
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Chunyan Liu <cyliu@suse.com>, qemu-devel@nongnu.org, Milos Vyletel <milos.vyletel@gmail.com>

On Wed, 06/18 18:02, Stefan Hajnoczi wrote:
> On Tue, Jun 17, 2014 at 11:08:48AM -0400, Milos Vyletel wrote:
> > I hope this is the right place to report this. I've noticed that I
> > can't run qemu-img convert on latest git version because it segfaults.
> > I've bisected the code and identified that this was caused by
> 
> Thanks for the bug report!

Thanks,

Pointer used withoug checking. I will post a patch and Cc you all.

Fam

> 
> > commit 6f482f742dd841b45297fb0e5f3d2c81779253be
> > Author: Chunyan Liu <cyliu@suse.com>
> > Date:   Thu Jun 5 17:21:01 2014 +0800
> > 
> >     raw-posix.c: replace QEMUOptionParameter with QemuOpts
> > 
> >     Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> >     Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> >     Signed-off-by: Chunyan Liu <cyliu@suse.com>
> >     Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > 
> > bisect log:
> > git bisect start
> > # bad: [af44da87e926ff64260b95f4350d338c4fc113ca] Merge
> > remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream'
> > into staging
> > git bisect bad af44da87e926ff64260b95f4350d338c4fc113ca
> > # good: [10f08a0a3435afea441db8d0981dbad49042c7cf] qemu-iotests: Test
> > converting to streamOptimized from small cluster size
> > git bisect good 10f08a0a3435afea441db8d0981dbad49042c7cf
> > # good: [1673e89e93e08cbfee7c9b552008e5b39469ad0e] Merge
> > remote-tracking branch 'remotes/kraxel/tags/pull-sdl-3' into staging
> > git bisect good 1673e89e93e08cbfee7c9b552008e5b39469ad0e
> > # good: [a491af471bf8f1188b2665f54d109065d4591e45] json-parser: drop
> > superfluous assignment for token variable
> > git bisect good a491af471bf8f1188b2665f54d109065d4591e45
> > # good: [10582ff832798813ba3a17f13f3ab46250388b47] spapr: Add ibm,
> > chip-id property in device tree
> > git bisect good 10582ff832798813ba3a17f13f3ab46250388b47
> > # good: [6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae] target-ppc: Make
> > use of gen_spr_book3s_altivec() for POWER7/8
> > git bisect good 6a1eed3f49e0fc5ef94906c0eab5314bc32bc8ae
> > # bad: [bd0cf596fd1200d162e5655adff9c06d40dbdd14] rbd.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad bd0cf596fd1200d162e5655adff9c06d40dbdd14
> > # good: [8559e45e51edd22dd48d54cce8b0521e6339f3e9] QemuOpts: add
> > conversion between QEMUOptionParameter to QemuOpts
> > git bisect good 8559e45e51edd22dd48d54cce8b0521e6339f3e9
> > # good: [98c10b810a83a0f52b4b5a14a8a36ce0622cb01f] nfs.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect good 98c10b810a83a0f52b4b5a14a8a36ce0622cb01f
> > # good: [7ab74849a5724452b35982a6e7d658c25839f5e5] qed.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect good 7ab74849a5724452b35982a6e7d658c25839f5e5
> > # bad: [ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a] raw-win32.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad ddef76999396d93b2c7ddfc7e95d5c4bcdeac55a
> > # bad: [6f482f742dd841b45297fb0e5f3d2c81779253be] raw-posix.c: replace
> > QEMUOptionParameter with QemuOpts
> > git bisect bad 6f482f742dd841b45297fb0e5f3d2c81779253be
> > 
> > test script:
> > #!/bin/bash
> > 
> > make -j 24 clean
> > ./configure
> > make -j 24 qemu-img
> > 
> > ./qemu-img create -f raw ~/qemu-test.img 128M
> > 
> > ./qemu-img convert -p -f raw ~/qemu-test.img -O vmdk \
> >     -o adapter_type=lsilogic,subformat=streamOptimized,compat6 \
> >     ~/qemu-test.vmdk
> > 
> > [ -f ~/qemu-test.vmdk ] && ret=0 || ret=1
> > 
> > rm -f ~/qemu-test.{img,vmdk}
> > 
> > exit $ret
> > 
> > Milos
> >