From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxSvQ-0008Cx-4j
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:22:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxSvL-0002OA-EO
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:22:08 -0400
Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:53798)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxSvL-0002O4-6P
	for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:22:03 -0400
Received: by mail-wi0-f182.google.com with SMTP id bs8so2097416wib.15
	for <qemu-devel@nongnu.org>; Wed, 18 Jun 2014 20:22:02 -0700 (PDT)
Date: Thu, 19 Jun 2014 11:21:54 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140619032154.GA21236@stefanha-thinkpad.redhat.com>
References: <3e7848fff9d1ad0a72d43c61a3ddeabd0dc604f0.1403141617.git.peter.crosthwaite@xilinx.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN"
Content-Disposition: inline
In-Reply-To: <3e7848fff9d1ad0a72d43c61a3ddeabd0dc604f0.1403141617.git.peter.crosthwaite@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH block v1 1/2] block: m25p80: sync_page():
 Deindent function body.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com


--J/dobhs11T7y2rNN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 18, 2014 at 06:36:03PM -0700, Peter Crosthwaite wrote:
> sync_page() was conditionalizing it's whole fn body on the bdrv being
> non-null. Just return for the function immediately on NULL brdv and
> get rid of the big if.
>=20
> Makes implementation consistent with flash_zynq_area().
>=20
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>=20
>  hw/block/m25p80.c | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)

I don't know the hardware in question but from a block layer standpoint,
this series is fine.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--J/dobhs11T7y2rNN
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJToldSAAoJEJykq7OBq3PIY2YH/3Mo39xjlpLpMneIVDec+Koh
XAC+6QjdP5yhyHGaRhsGRvNaYnCRQ/P88/HVmaMVxm4E148EPMj7/Xno5H+PIuaq
qLGGCmKScn3fe/W7zJZz4v3FREIAX7zG0mpeag/iC8lRL43hHYNTwydAs3TwODww
PNPPgRipnY0iBPwmL2dRFGUIUbpfgLrVRchLmYAXP53gqoK6HlMGkc8kPb/I2/sK
gJBuuEmqjBA62In/IL7hQMY4ITepmBGopV1ur9qvFcBKjK3TGMzOXWkUL4gCVWbB
Ar2XyA06GtEESPhf9pbXTK+weW7nlqzutkFNWbONtrepFbqReCnPAAGgtEGkXCA=
=U6Bq
-----END PGP SIGNATURE-----

--J/dobhs11T7y2rNN--