From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxTU8-0007Ac-DY for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxTU2-0004Ob-A2 for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:58:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxTU2-0004ON-0F for qemu-devel@nongnu.org; Wed, 18 Jun 2014 23:57:54 -0400 Date: Thu, 19 Jun 2014 11:57:45 +0800 From: Amos Kong Message-ID: <20140619035744.GD32534@z.redhat.com> References: <1403108653-26765-1-git-send-email-akong@redhat.com> <1403108653-26765-5-git-send-email-akong@redhat.com> <20140619034908.GC21236@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline In-Reply-To: <20140619034908.GC21236@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, afaerber@suse.de --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote: > On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote: > > + for (i =3D MIN_PCI_SLOT; i <=3D MAX_PCI_SLOT; i++) { > > + for (j =3D MAX_PCI_FUNC; j >=3D 0; j--) { > > + if (j =3D=3D MAX_PCI_FUNC) { > > + qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0); > > + } >=20 > Why is only drv-%x.0 deleted? Previous revisions of this patch series > deleted all drives. Hot-unplug any single function, all functions in the slot will be removed. So once is enough. =20 > Stefan --=20 Amos. --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJTol+4AAoJELxSv6I5vP9jTV4P/1Z3LmIcKbAtJRAcLvxzdqu6 NvXNTqJ5FTWkQDnV8HDF8F0fSCUjGHdfctXSuSwHnrjQFyKLTrwSEzxusERRPPwA dIR1+tKBxIBJW8ot7BNOBMK36Pe6CJnIH1+40TkX50kmOwtbMqyQjuTt3uAppHnT LD/T7d3usoxJ6eMa38fUdFLYGlL/7H1x9rSzctYNe5zmEG+FL4sh5dFiFF2lF2T3 BQxtcvU1ZfwarS3KN7a7KEAZDpglyXaq5GnPzuGEbh1Lj3M7u8E+JOE3Xdl+VtRy 9CGvM2Kn69yoYSpYX3sAFejunxRrqaga+bCVjMMp3q+4N/RPib6kdqC0SZMgJS54 5hkMUM329r2Z0xdqI8u6nMKgZIOnngFAMNhsIlwgaH0TD/ER3qA9OTNcZP5PgfLh ysQ0ZLsnlPbQJAahECGJCAwEJYJOvYBqXMV0fle02l8T3moeWCSsxQLfDp6IJKfA ZMZi/nqCGPlPg13ItzPLVSfzSo0DAzdlEzmYR711S57w23/mZKBOvs0zD8NuZjVw e3tPC+d+L1itg6oAq0J/8ixvq9G3z+tR7uz+0ZXC6UWx61tSgXTCQze+lNbS9u3g nkeuTYjUpqyfKqiadWLWMkLO/IYRcjNcmhF7/iiivWDlwJeirrm9XquawSGups/6 YmFmSdyaUHdTMpfhlxqx =zqMv -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--