From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WxUAp-0005I2-EM
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:42:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WxUAj-0000A1-9I
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:42:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36638)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1WxUAi-00009p-W5
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:42:01 -0400
Date: Thu, 19 Jun 2014 12:41:52 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20140619044152.GB3558@z.redhat.com>
References: <1403108653-26765-1-git-send-email-akong@redhat.com>
	<1403108653-26765-4-git-send-email-akong@redhat.com>
	<53A1C1C5.4020608@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <53A1C1C5.4020608@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop()
 to virtblk_init()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, arei.gonglei@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com

On Wed, Jun 18, 2014 at 06:43:49PM +0200, Andreas F=E4rber wrote:
> Am 18.06.2014 18:24, schrieb Amos Kong:
> > I want to add a new subtest in virtio-blk-test.c, it will start
> > guest without network. The original pci_init() did nothing, but
> > it's good to reserve a very simple initialization testing.
> >=20
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> >  tests/virtio-blk-test.c | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> >=20
> > diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> > index d53f875..0fdec01 100644
> > --- a/tests/virtio-blk-test.c
> > +++ b/tests/virtio-blk-test.c
> > @@ -12,9 +12,12 @@
> >  #include "libqtest.h"
> >  #include "qemu/osdep.h"
> > =20
> > -/* Tests only initialization so far. TODO: Replace with functional t=
ests */
>=20
> One thing of note here is that this TODO is neither resolved here nor
> later in this series. Stefan had originally asked me to add it.


We don't treated pci_nop() as test in the past, but in this patch we
rename and split it as a single initialization testing.

We also added another functional test by next patchset.

So we can remove the 'TODO'
=20
> Andreas
>=20
> > -static void pci_nop(void)
> > +/* Tests only initialization */
> > +static void virtblk_init(void)
> >  {
> > +    qtest_start("-drive id=3Ddrv0,if=3Dnone,file=3D/dev/null "
> > +                "-device virtio-blk-pci,drive=3Ddrv0");
> > +    qtest_end();
> >  }
> > =20
> >  int main(int argc, char **argv)
> [snip]
>=20
> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn=
berg

--=20
			Amos.