From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxUFi-0006lT-NQ for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxUFZ-0001N0-Aw for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:47:10 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:59246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxUFZ-0001Mu-3c for qemu-devel@nongnu.org; Thu, 19 Jun 2014 00:47:01 -0400 Received: by mail-wi0-f179.google.com with SMTP id cc10so2158740wib.12 for ; Wed, 18 Jun 2014 21:47:00 -0700 (PDT) Date: Thu, 19 Jun 2014 12:46:51 +0800 From: Stefan Hajnoczi Message-ID: <20140619044651.GG21236@stefanha-thinkpad.redhat.com> References: <1402912857-10509-1-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oOB74oR0WcNeq9Zb" Content-Disposition: inline In-Reply-To: <1402912857-10509-1-git-send-email-benoit.canet@irqsave.net> Subject: Re: [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com --oOB74oR0WcNeq9Zb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 16, 2014 at 12:00:53PM +0200, Beno=EEt Canet wrote: > in v10: > address max comments >=20 > Beno=EEt Canet (4): > quorum: Add the rewrite-corrupted parameter to quorum > block: Add node-name argument to drive-mirror > block: Add replaces argument to drive-mirror > qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror > node-name mode. >=20 > block.c | 17 ++++ > block/mirror.c | 60 +++++++++++--- > block/quorum.c | 97 ++++++++++++++++++++-- > blockdev.c | 41 +++++++++- > hmp.c | 1 + > include/block/block.h | 4 + > include/block/block_int.h | 3 + > qapi/block-core.json | 13 ++- > qmp-commands.hx | 5 ++ > tests/qemu-iotests/041 | 196 +++++++++++++++++++++++++++++++++++++++= +++++- > tests/qemu-iotests/041.out | 4 +- > tests/qemu-iotests/081 | 15 +++- > tests/qemu-iotests/081.out | 10 +++ > 13 files changed, 436 insertions(+), 30 deletions(-) I'm happy with this but need to review Jeff's series first. Your series assumes that nodes are protected by op blockers, which they currently aren't (only the root node has op blockers). So we need a solution to that before it's safe to allow operations on nodes - I think Jeff's series tackles that. Reviewed-by: Stefan Hajnoczi --oOB74oR0WcNeq9Zb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJToms7AAoJEJykq7OBq3PIm/QH/2u6Hyzy5PYcjatVughcO3TK /KaTbnI43P7i6nfxLNKpeo9YR6LmZsw083b/rM8oTY8MdjhVTKaLSdHt1RvX72/r MU++huMlmgHU16ET3vyshym0ayZDOl+/bjxJW2WT4wT8ROQqnq3oBFDTkiiLmQJE qdvelXZB6mKgiF2iQmy/+N5JMk3sRKw/jWMpWHyYdGamZYezIrbCPk4Hcz0TiNks 3em0bk6lcsouWo06bnW6OkwNpnH+k2IGyiPnRyqJSrSvhNygGsdP/H1XyRIZjFHx DkbKHYzx6wESRVMTK7lrQEcxraN7gaTAasOluvIIcI/JtPAfhbtwSERAA4O3n/w= =D9j6 -----END PGP SIGNATURE----- --oOB74oR0WcNeq9Zb--