From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers
Date: Thu, 19 Jun 2014 14:24:36 +0800 [thread overview]
Message-ID: <20140619062436.GH21236@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1403043250-28472-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote:
> For some protocol block drivers, the "filename" attribute in their BDSs
> is unset due to bdrv_file_open() removing it from the options QDict
> before bdrv_open_common() is able to copy it into the BDS. Fix this by
> not removing it until until bdrv_open_common() has indeed copied it.
>
>
> Max Reitz (2):
> block: Do not prematurely remove "filename"
> iotests: Add test for set "filename" for NBD
>
> block.c | 12 ++++++--
> tests/qemu-iotests/097 | 72 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/097.out | 13 +++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 95 insertions(+), 3 deletions(-)
> create mode 100755 tests/qemu-iotests/097
> create mode 100644 tests/qemu-iotests/097.out
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-06-19 6:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 22:14 [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers Max Reitz
2014-06-17 22:14 ` [Qemu-devel] [PATCH 1/2] block: Do not prematurely remove "filename" Max Reitz
2014-06-18 13:42 ` Benoît Canet
2014-06-17 22:14 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for set "filename" for NBD Max Reitz
2014-06-18 13:47 ` Benoît Canet
2014-06-18 18:14 ` Max Reitz
2014-06-19 6:24 ` Stefan Hajnoczi [this message]
2014-06-23 8:35 ` [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers Stefan Hajnoczi
2014-06-26 18:58 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619062436.GH21236@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).