From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxVmE-0002k2-OQ
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 02:24:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxVm9-00045B-AM
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 02:24:50 -0400
Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:35850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WxVm9-000455-1s
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 02:24:45 -0400
Received: by mail-we0-f175.google.com with SMTP id k48so1851479wev.34
	for <qemu-devel@nongnu.org>; Wed, 18 Jun 2014 23:24:44 -0700 (PDT)
Date: Thu, 19 Jun 2014 14:24:36 +0800
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140619062436.GH21236@stefanha-thinkpad.redhat.com>
References: <1403043250-28472-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qM81t570OJUP5TU/"
Content-Disposition: inline
In-Reply-To: <1403043250-28472-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for
 certain drivers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>


--qM81t570OJUP5TU/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote:
> For some protocol block drivers, the "filename" attribute in their BDSs
> is unset due to bdrv_file_open() removing it from the options QDict
> before bdrv_open_common() is able to copy it into the BDS. Fix this by
> not removing it until until bdrv_open_common() has indeed copied it.
>=20
>=20
> Max Reitz (2):
>   block: Do not prematurely remove "filename"
>   iotests: Add test for set "filename" for NBD
>=20
>  block.c                    | 12 ++++++--
>  tests/qemu-iotests/097     | 72 ++++++++++++++++++++++++++++++++++++++++=
++++++
>  tests/qemu-iotests/097.out | 13 +++++++++
>  tests/qemu-iotests/group   |  1 +
>  4 files changed, 95 insertions(+), 3 deletions(-)
>  create mode 100755 tests/qemu-iotests/097
>  create mode 100644 tests/qemu-iotests/097.out

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--qM81t570OJUP5TU/
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJTooIkAAoJEJykq7OBq3PIr68IAITzRWsexFlj+7qthEU07Onp
QK3lhBZj4KG7tR25E2bxHY38r+Q9i8TqZTWZfFn05bZ2KgPfHYYtnlQSzFpzpkVd
7okCs7L1+8TIXA2XSRUokKtv9IXBfA3tOUrbrQPhXXfcFkzCcd7HciTdkrbtAMZV
SedOtgzFrpXudL2u2Ig186kVTvGfvOA+vbjSkC8clhG3RfI3SyirDQvLHQBxhTP9
g8lEXlKaL/u7NN3e47yrvEQ+bCXIbEDBiyv/+m85h6VVGJOo3CuMawpDE/wX921E
Zkp49pjbdp9wzDWErTak9Dyf45+I8DS5f5MrgAdrSA4r5p9VK9IVyGl/+QWQaFU=
=q83T
-----END PGP SIGNATURE-----

--qM81t570OJUP5TU/--