From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, Benoit Canet <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v10 3/4] block: Add replaces argument to drive-mirror
Date: Thu, 19 Jun 2014 17:19:35 +0800 [thread overview]
Message-ID: <20140619091935.GT21236@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1402912857-10509-4-git-send-email-benoit.canet@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Mon, Jun 16, 2014 at 12:00:56PM +0200, Benoît Canet wrote:
> +BlockDriverState *check_to_replace_node(const char *node_name, Error **errp)
> +{
> + BlockDriverState *to_replace_bs = bdrv_find_node(node_name);
> + if (!to_replace_bs) {
> + error_setg(errp, "Node name '%s' not found",
> + node_name);
> + return NULL;
> + }
> +
> + if (bdrv_op_is_blocked(to_replace_bs, BLOCK_OP_TYPE_REPLACE, errp)) {
> + return NULL;
> + }
Currently bdrv_op_is_blocked(to_replace_bs, BLOCK_OP_TYPE_REPLACE, errp)
is not effective since child nodes never have op blockers. Only the
root node/drive has op blockers.
We discussed propagating blockers to child nodes. Can you send a patch
to address this? I think Jeff will need to rebase his node-name series
too.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-06-19 9:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 10:00 [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations Benoît Canet
2014-06-16 10:00 ` [Qemu-devel] [PATCH v10 1/4] quorum: Add the rewrite-corrupted parameter to quorum Benoît Canet
2014-06-16 10:00 ` [Qemu-devel] [PATCH v10 2/4] block: Add node-name argument to drive-mirror Benoît Canet
2014-06-16 10:00 ` [Qemu-devel] [PATCH v10 3/4] block: Add replaces " Benoît Canet
2014-06-19 9:19 ` Stefan Hajnoczi [this message]
2014-06-27 11:57 ` Kevin Wolf
2014-06-27 12:03 ` Benoît Canet
2014-06-27 12:53 ` Benoît Canet
2014-06-27 13:37 ` Kevin Wolf
2014-06-27 14:30 ` Benoît Canet
2014-06-16 10:00 ` [Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode Benoît Canet
2014-06-17 16:17 ` Max Reitz
2014-06-17 18:19 ` Benoît Canet
2014-06-17 18:20 ` Max Reitz
2014-06-17 18:21 ` Max Reitz
2014-06-19 4:46 ` [Qemu-devel] [PATCH v10 0/4] Quorum maintainance operations Stefan Hajnoczi
2014-06-27 12:19 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619091935.GT21236@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).