From: Stefan Hajnoczi <stefanha@redhat.com>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create
Date: Thu, 19 Jun 2014 17:43:37 +0800 [thread overview]
Message-ID: <20140619094337.GA2766@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1402983935-14920-1-git-send-email-namei.unix@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Tue, Jun 17, 2014 at 01:45:35PM +0800, Liu Yuan wrote:
> Following command
>
> qemu-img create -f qcow2 sheepdog:test 20g
>
> will cause core dump because aio_context is NULL in sd_create. We should
> initialize it by qemu_get_aio_context() to avoid NULL dereference.
>
> Cc: qemu-devel@nongnu.org
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Liu Yuan <namei.unix@gmail.com>
> ---
> block/sheepdog.c | 1 +
> 1 file changed, 1 insertion(+)
Sorry about this, it's my fault.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-06-19 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 5:45 [Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create Liu Yuan
2014-06-19 9:43 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619094337.GA2766@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=namei.unix@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).