From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxYsv-0006G7-9s for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxYsq-00030U-Ry for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:43:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxYsq-00030O-Jd for qemu-devel@nongnu.org; Thu, 19 Jun 2014 05:43:52 -0400 Date: Thu, 19 Jun 2014 17:43:37 +0800 From: Stefan Hajnoczi Message-ID: <20140619094337.GA2766@stefanha-thinkpad.redhat.com> References: <1402983935-14920-1-git-send-email-namei.unix@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: <1402983935-14920-1-git-send-email-namei.unix@gmail.com> Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix NULL dereference in sd_create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liu Yuan Cc: Kevin Wolf , sheepdog@lists.wpkg.org, qemu-devel@nongnu.org --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 17, 2014 at 01:45:35PM +0800, Liu Yuan wrote: > Following command >=20 > qemu-img create -f qcow2 sheepdog:test 20g >=20 > will cause core dump because aio_context is NULL in sd_create. We should > initialize it by qemu_get_aio_context() to avoid NULL dereference. >=20 > Cc: qemu-devel@nongnu.org > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.c | 1 + > 1 file changed, 1 insertion(+) Sorry about this, it's my fault. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --9amGYk9869ThD9tj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTorDJAAoJEJykq7OBq3PIviIH/0ljphkOZOvLcBYLmdklez+K 3l1KV3+WV0l4ewmPcK3pMP42AEcziAupmwIbJZ52Sj+EU65qJadtcFwmFpVHO2N1 LcRXo/tRoOxVGwE6bsD9cPGoHXLoGjhvEzYGWNO9FBZYRWDtvTYX8TAkWV8k6iJJ vfkyaEu8NQVyRoH++n5A19NqDQZAiqgwMTq57moDuYmJrDf/HiVxm0oH22pmSmPs 7stSlUk21ptUZE1N4fc/PVXuIcQzlLOp+SB9CJo0///WK2iJ1/jLwfx3mtNFEfPF aAC8vgfo8DZjUg9/x3cWWDX9g2Et00HNAy0lgHuT2ViVowS4vjcdkH7JzOw06UE= =Zbai -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--