From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38671)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxaLa-0002EC-0O
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 07:17:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxaLN-0005Th-N4
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 07:17:37 -0400
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:51902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxaLN-0005ST-DR
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 07:17:25 -0400
Received: from /spool/local
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Thu, 19 Jun 2014 12:17:23 +0100
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 18D1617D8042
	for <qemu-devel@nongnu.org>; Thu, 19 Jun 2014 12:18:46 +0100 (BST)
Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com
	[9.149.37.251])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s5JBHLI323593048
	for <qemu-devel@nongnu.org>; Thu, 19 Jun 2014 11:17:21 GMT
Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s5JBHK5J007813
	for <qemu-devel@nongnu.org>; Thu, 19 Jun 2014 05:17:21 -0600
Date: Thu, 19 Jun 2014 13:17:18 +0200
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20140619131718.5174f344@bahia.local>
In-Reply-To: <20140619104015.GB7139@grmbl.mre>
References: <20140613111703.22108.14322.stgit@bahia.local>
	<20140613111808.22108.65439.stgit@bahia.local>
	<20140619104015.GB7139@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v8 01/20] virtio-serial: don't migrate the
	config space
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Juan Quintela <quintela@redhat.com>, aneesh.kumar@linux.vnet.ibm.com, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Thu, 19 Jun 2014 16:10:15 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Fri) 13 Jun 2014 [13:18:42], Greg Kurz wrote:
> > The device configuration is set at realize time and never changes. It
> > should not be migrated as it is done today. For the sake of compatibility,
> > let's just skip them at load time.
> > 
> > Signed-off-by: Alexander Graf <agraf@suse.de>
> 
> The author field should also mention Alex instead of you, I suppose,
> since it was authored by him.
> 

I'll add a From: line.

> Patch looks good.
> 
> 		Amit
> 

Thanks for the review.

-- 
Gregory Kurz                                     kurzgreg@fr.ibm.com
                                                 gkurz@linux.vnet.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.