From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wxcng-0002XR-I6 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxcnX-0001vD-OU for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:54:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxcnX-0001v9-GL for qemu-devel@nongnu.org; Thu, 19 Jun 2014 09:54:39 -0400 Date: Thu, 19 Jun 2014 16:54:58 +0300 From: "Michael S. Tsirkin" Message-ID: <20140619135458.GB4544@redhat.com> References: <1402939751-8371-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1402939751-8371-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v1 0/3] e1000: link auto-negotiation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: romain@dolbeau.org, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote: > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). > > - allow mii_tool on linux access to all the phy registers and flags > it requires in order to report a successfully auto-negotiated link. > > - inject LSC interrupt upon successful link auto-negotiation (required > by stock OS X e1000 driver). > > See additional prose following commit logs in 2/3 (making up excuses > for checkpatch error) and 3/3 (further thoughts on OS X vs. Linux/Windows > re. auto-negotiation and LSC injection). > > Thanks much, > Gabriel Looks good to me. We should be careful to bring link immediately up and not to run the timer if running in legacy pc compatibility mode: QEMU 1.3 does not support link auto-negotiation emulation, so if we migrate during auto negotiation, after migration the link will be down. > Gabriel L. Somlo (3): > e1000: emulate auto-negotiation during external link status change > e1000: improve auto-negotiation reporting via mii-tool > e1000: signal guest on successful link auto-negotiation > > hw/net/e1000.c | 24 +++++++++++++++++++----- > hw/net/e1000_regs.h | 3 +++ > 2 files changed, 22 insertions(+), 5 deletions(-) > > -- > 1.9.3