From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxfCk-0005Ek-F1 for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:29:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WxfCc-0005ta-DG for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:28:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WxfCc-0005tH-3b for qemu-devel@nongnu.org; Thu, 19 Jun 2014 12:28:42 -0400 Date: Thu, 19 Jun 2014 19:29:00 +0300 From: "Michael S. Tsirkin" Message-ID: <20140619162900.GA21828@redhat.com> References: <1403193336-32101-1-git-send-email-somlo@cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403193336-32101-1-git-send-email-somlo@cmu.edu> Subject: Re: [Qemu-devel] [PATCH v2 0/4] e1000: link auto-negotiation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: romain@dolbeau.org, agraf@suse.de, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Thu, Jun 19, 2014 at 11:55:32AM -0400, Gabriel L. Somlo wrote: > New in v2: > > - checking for E1000_FLAG_AUTONEG in s->compat_flags when deciding > whether to run the auto-negotiation timer vs. simply forcing the > link up during e1000_set_link_status() > > - grouped E1000_FLAG_AUTONEG check in s->compat_flags tighter with > the rest of the auto-negotiation checks in the two other locations > they appear in the source code (hopefully improving clarity). > > - added patch to move the auto-negotiation timer function past set_ics() > to avoid the need for a forward declaration. > Applied, thanks everyone. > This series contains a few fixes and improvements in the emulation > of link auto-negotiation: > > - use auto-negotiation when the link is bounced externally (e.g. via > set_link down/up on the qemu monitor command line). > > - allow mii_tool on linux access to all the phy registers and flags > it requires in order to report a successfully auto-negotiated link. > > - inject LSC interrupt upon successful link auto-negotiation (required > by stock OS X e1000 driver). > > Gabriel L. Somlo (4): > e1000: emulate auto-negotiation during external link status change > e1000: improve auto-negotiation reporting via mii-tool > e1000: move e1000_autoneg_timer() to after set_ics() > e1000: signal guest on successful link auto-negotiation > > hw/net/e1000.c | 59 ++++++++++++++++++++++++++++++----------------------- > hw/net/e1000_regs.h | 3 +++ > 2 files changed, 36 insertions(+), 26 deletions(-) > > -- > 1.9.3