From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59921)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wxh03-0007cb-HM
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 14:23:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wxgzx-0005yW-MA
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 14:23:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Wxgzx-0005yH-Cq
	for qemu-devel@nongnu.org; Thu, 19 Jun 2014 14:23:45 -0400
Date: Thu, 19 Jun 2014 21:24:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140619182409.GA22948@redhat.com>
References: <20140619173410.7378.82319.stgit@3820>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140619173410.7378.82319.stgit@3820>
Subject: Re: [Qemu-devel] [PATCH v2] qtest: enable vhost-user-test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
Cc: snabb-devel@googlegroups.com, qemu-devel@nongnu.org, tech@virtualopensystems.com

On Thu, Jun 19, 2014 at 08:35:42PM +0300, Nikolay Nikolaev wrote:
> Use qtest-obj-y to get the right library order. CONFIG_POSIX ensures
> mingw compilation won't break.
> 
> Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>

okay but why does non posix work without -lutil and posix doesn't?

> ---
>  0 files changed
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 4caf7de..5661d52 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -156,7 +156,7 @@ gcov-files-i386-y += hw/usb/hcd-ehci.c
>  gcov-files-i386-y += hw/usb/hcd-uhci.c
>  gcov-files-i386-y += hw/usb/dev-hid.c
>  gcov-files-i386-y += hw/usb/dev-storage.c
> -#check-qtest-i386-y += tests/vhost-user-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_POSIX) += tests/vhost-user-test$(EXESUF)
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y = $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
> @@ -323,11 +323,14 @@ tests/es1370-test$(EXESUF): tests/es1370-test.o
>  tests/intel-hda-test$(EXESUF): tests/intel-hda-test.o
>  tests/ioh3420-test$(EXESUF): tests/ioh3420-test.o
>  tests/usb-hcd-ehci-test$(EXESUF): tests/usb-hcd-ehci-test.o $(libqos-pc-obj-y)
> -tests/vhost-user-test$(EXESUF): tests/vhost-user-test.o qemu-char.o qemu-timer.o libqemuutil.a libqemustub.a
> +tests/vhost-user-test$(EXESUF): tests/vhost-user-test.o qemu-char.o qemu-timer.o $(qtest-obj-y)
>  tests/qemu-iotests/socket_scm_helper$(EXESUF): tests/qemu-iotests/socket_scm_helper.o
>  tests/test-qemu-opts$(EXESUF): tests/test-qemu-opts.o libqemuutil.a libqemustub.a
>  
> -#LIBS+= -lutil
> +
> +ifeq ($(CONFIG_POSIX),y)
> +LIBS+= -lutil
> +endif
>  
>  # QTest rules
>