From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH net v1 1/1] net: cadence_gem: Convert to realize()
Date: Fri, 20 Jun 2014 17:12:36 +0800 [thread overview]
Message-ID: <20140620091236.GD11029@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <2c4e88786e53d6e1d2a474d2bc07f2630ccdafc9.1403153507.git.peter.crosthwaite@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
On Wed, Jun 18, 2014 at 09:54:17PM -0700, Peter Crosthwaite wrote:
> SysBusDevice::init is deprecated. Convert to Object::init and
> Device::realize as prescribed by QOM conventions.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>
> hw/net/cadence_gem.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
Looks fine. Waiting for Andreas' review before merging.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-06-20 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 4:54 [Qemu-devel] [PATCH net v1 1/1] net: cadence_gem: Convert to realize() Peter Crosthwaite
2014-06-20 9:12 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620091236.GD11029@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).