From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55781)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxuGl-0004XW-QE
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:34:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxuGc-0000u7-RS
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:33:59 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:60550)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gkurz@linux.vnet.ibm.com>) id 1WxuGc-0000tZ-Il
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 04:33:50 -0400
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <gkurz@linux.vnet.ibm.com>;
	Fri, 20 Jun 2014 09:33:49 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D8168219004D
	for <qemu-devel@nongnu.org>; Fri, 20 Jun 2014 09:33:35 +0100 (BST)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id s5K8Xl2G34865402
	for <qemu-devel@nongnu.org>; Fri, 20 Jun 2014 08:33:47 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s5K8Xj7Q017081
	for <qemu-devel@nongnu.org>; Fri, 20 Jun 2014 02:33:47 -0600
Date: Fri, 20 Jun 2014 10:33:35 +0200
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
Message-ID: <20140620103335.677d4d50@bahia.local>
In-Reply-To: <53A3EFCB.5090501@redhat.com>
References: <20140613111703.22108.14322.stgit@bahia.local>
	<20140613112454.22108.70328.stgit@bahia.local>
	<53A3EFCB.5090501@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v8 17/20] virtio-scsi: use virtio wrappers
 to access headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, Juan Quintela <quintela@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>, aneesh.kumar@linux.vnet.ibm.com, Stefan Hajnoczi <stefanha@redhat.com>, Amit Shah <amit.shah@redhat.com>, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>

On Fri, 20 Jun 2014 10:24:43 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 13/06/2014 13:24, Greg Kurz ha scritto:
> > From: Rusty Russell <rusty@rustcorp.com.au>
> >
> > Note that st*_raw and ld*_raw are effectively replaced by st*_p and ld*=
_p.
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> > Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
> > [ pass VirtIODevice * to memory accessors,
> >   fix missing tswap32 in virtio_scsi_push_event() by C=C3=A9dric Le Goa=
ter,
> >   Greg Kurz <gkurz@linux.vnet.ibm.com> ]
> > Cc: C=C3=A9dric Le Goater <clg@fr.ibm.com>
>=20
> Be careful that, in the meanwhile, two tswap32s's have been added by=20
> commit b0b4ea1 (virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq=20
> fields, 2014-06-10): one in virtio_scsi_do_tmf, one in=20
> virtio_scsi_handle_ctrl.
>=20
> Paolo
>=20

Yeah I saw these. Thanks.

--=20
Gregory Kurz                                     kurzgreg@fr.ibm.com
                                                 gkurz@linux.vnet.ibm.com
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.