From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58628)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1Wy4Cq-000722-IA
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 15:10:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1Wy4Ch-000215-Ef
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 15:10:36 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:37053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nacc@linux.vnet.ibm.com>) id 1Wy4Cg-0001zn-Ot
	for qemu-devel@nongnu.org; Fri, 20 Jun 2014 15:10:27 -0400
Received: from /spool/local
	by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nacc@linux.vnet.ibm.com>;
	Fri, 20 Jun 2014 13:10:25 -0600
Date: Fri, 20 Jun 2014 12:10:00 -0700
From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Message-ID: <20140620191000.GX16644@linux.vnet.ibm.com>
References: <1402905233-26510-1-git-send-email-aik@ozlabs.ru>
	<1402905233-26510-4-git-send-email-aik@ozlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1402905233-26510-4-git-send-email-aik@ozlabs.ru>
Subject: Re: [Qemu-devel] [PATCH 3/7] spapr: Refactor spapr_populate_memory()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 16.06.2014 [17:53:49 +1000], Alexey Kardashevskiy wrote:
> Current QEMU does not support memoryless NUMA nodes.
> This prepares SPAPR for that.
> 
> This moves 2 calls of spapr_populate_memory_node() into
> the existing loop which handles nodes other than than
> the first one.

<snip>

> @@ -719,6 +704,12 @@ static int spapr_populate_memory(sPAPREnvironment *spapr, void *fdt)
>                  node_size = ram_size - mem_start;
>              }
>          }
> +        if (!mem_start) {
> +            /* ppc_spapr_init() checks for rma_size <= node0_size already */
> +            spapr_populate_memory_node(fdt, i, 0, spapr->rma_size);
> +            mem_start += spapr->rma_size;
> +            node_size -= spapr->rma_size;
> +        }

Why is this needed to be separate? The RMA fits in the first node, per
the comment and the prior checks, so can't we just leave the first node
alone?

-Nish