Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS

[Paul Burton <paulburton89@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Sat, Jun 21, 2014 at 02:02:55PM +0300, Riku Voipio wrote:
> On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote:
> > MIPS requires the pad field to 64b-align the data field just as ARM
> > does.
> 
> Is this true for the 64bit mips also?

It appears so, good catch :)

Paul

> > Signed-off-by: Paul Burton <paul@archlinuxmips.org>
> > ---
> >  linux-user/syscall_defs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> > index 69c3982..9fcb723 100644
> > --- a/linux-user/syscall_defs.h
> > +++ b/linux-user/syscall_defs.h
> > @@ -2528,7 +2528,7 @@ typedef union target_epoll_data {
> >  
> >  struct target_epoll_event {
> >      uint32_t events;
> > -#ifdef TARGET_ARM
> > +#if defined(TARGET_ARM) || defined(TARGET_MIPS)
> >      uint32_t __pad;
> >  #endif
> >      target_epoll_data_t data;
> > -- 
> > 2.0.0
> > 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]