From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyPen-00066T-Rs for qemu-devel@nongnu.org; Sat, 21 Jun 2014 14:04:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WyPei-0007O7-0G for qemu-devel@nongnu.org; Sat, 21 Jun 2014 14:04:53 -0400 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:56076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WyPeh-0007Ns-P5 for qemu-devel@nongnu.org; Sat, 21 Jun 2014 14:04:47 -0400 Received: by mail-we0-f170.google.com with SMTP id w61so5142279wes.29 for ; Sat, 21 Jun 2014 11:04:46 -0700 (PDT) Date: Sat, 21 Jun 2014 19:04:42 +0100 From: Paul Burton Message-ID: <20140621180442.GC3158@gmail.com> References: <1402849113-11402-1-git-send-email-paul@archlinuxmips.org> <1402849113-11402-8-git-send-email-paul@archlinuxmips.org> <20140621110255.GC23713@afflict.kos.to> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kVXhAStRUZ/+rrGn" Content-Disposition: inline In-Reply-To: <20140621110255.GC23713@afflict.kos.to> Subject: Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Riku Voipio Cc: qemu-devel@nongnu.org, Paul Burton --kVXhAStRUZ/+rrGn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 21, 2014 at 02:02:55PM +0300, Riku Voipio wrote: > On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote: > > MIPS requires the pad field to 64b-align the data field just as ARM > > does. >=20 > Is this true for the 64bit mips also? It appears so, good catch :) Paul > > Signed-off-by: Paul Burton > > --- > > linux-user/syscall_defs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > > index 69c3982..9fcb723 100644 > > --- a/linux-user/syscall_defs.h > > +++ b/linux-user/syscall_defs.h > > @@ -2528,7 +2528,7 @@ typedef union target_epoll_data { > > =20 > > struct target_epoll_event { > > uint32_t events; > > -#ifdef TARGET_ARM > > +#if defined(TARGET_ARM) || defined(TARGET_MIPS) > > uint32_t __pad; > > #endif > > target_epoll_data_t data; > > --=20 > > 2.0.0 > >=20 --kVXhAStRUZ/+rrGn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJTpck6AAoJENzvn0paErs5l/sP/3zbFnSmG0uZw/J5thIc5UHJ 2ve4Hx8IJ+4nHaKC7K2CYuybA0G/rVKC9ZxVpOMa+euh84ztNl3xfTPBWc5dcCOc LD9reah6tIR7+E5bklJi/WJXCSssE3NVZ06bhoEHnsSQlkJfEuz+a/5dB04ReLWO Sf0zwyUT4Rc2Q4cZAxeXoq2WrwQejfI+FUuqpjzH8dGw+kaIfCuPZeVhHjTV+Gv+ oih3FySoIRxWXOpeGhTUk6hjzLjy23fy+i4XiOoopACeIW+jGGNNL27r90eyPwFa u7+eOGJjgzs0EXKTiVKLrhQVDvlTJ0BqAuFVcO16QiiIxlmWt/1HjsBeiMOCPXBx jIvSxPagDxJYIN2a2y/Ck+Ta0F/AIsG7U/bJnKXH05Gsw2HbUYsq3MtIEtuTBlTA teo35qSdF+jus+IbDPM/BFaSqjDO9GNefhHX08NdVxvi1Rd7EWm9cBzdYYZUl7Dh xkuFJa7IGtX5qaRdvhCWTgu5iS35EssGcjvmtrip5ytR5zxAMQa4wHslm8qXVvFZ kgQ4dVz4ApYlBos7fcX1pjrb0wimerMZ8Y4gaDyZMtNiTeKFHRLBstQeQUA7JzOn jDobAUJYdrChqai/j/dZEYk9BXSbjq+JhhhCtzb/WXDFKFBrYfJqlgrvAKo/zjn6 1otMXz5JwvweqnkJ0Qd2 =xXoR -----END PGP SIGNATURE----- --kVXhAStRUZ/+rrGn--