From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16
Date: Sat, 21 Jun 2014 22:29:33 +0200 [thread overview]
Message-ID: <20140621202933.GC27000@hall.aurel32.net> (raw)
In-Reply-To: <CAFEAcA9SpfpSviHezTp=_Mbsk8whHJv75Wv=co+_n+XU2Wpw0Q@mail.gmail.com>
On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote:
> On 21 June 2014 20:35, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > The roundAndPackFloat16 function should return a float16 value, not a
> > float32 one. Fix that.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Agreed, though I don't think it has any effect on the results.
No, it doesn't have any effect on the results, but it produces slightly
less optimized code. The main problem there is that it fails to build
when enforcing type checking, though less and less targets are compiling
when it is enabled.
> Can we have the usual "ok under softfloat 2a or 2b license"
> confirmation, please?
Yes, I am fine to license this patch under softfloat 2a or 2b license.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2014-06-21 20:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 19:35 [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16 Aurelien Jarno
2014-06-21 20:06 ` Peter Maydell
2014-06-21 20:29 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621202933.GC27000@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).