[Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

[Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

[Aurelien Jarno]

The roundAndPackFloat16 function should return a float16 value, not a
float32 one. Fix that.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 fpu/softfloat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index e00a6fb..3b19736 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -3209,7 +3209,7 @@ static float16 packFloat16(flag zSign, int_fast16_t zExp, uint16_t zSig)
 | Binary Floating-Point Arithmetic.
 *----------------------------------------------------------------------------*/
 
-static float32 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
+static float16 roundAndPackFloat16(flag zSign, int_fast16_t zExp,
                                    uint32_t zSig, flag ieee STATUS_PARAM)
 {
     int maxexp = ieee ? 29 : 30;
-- 
1.7.10.4

Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

[Peter Maydell]

On 21 June 2014 20:35, Aurelien Jarno <aurelien@aurel32.net> wrote:
> The roundAndPackFloat16 function should return a float16 value, not a
> float32 one. Fix that.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Agreed, though I don't think it has any effect on the results.
Can we have the usual "ok under softfloat 2a or 2b license"
confirmation, please?

thanks
-- PMM

Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

[Aurelien Jarno]

On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote:
> On 21 June 2014 20:35, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > The roundAndPackFloat16 function should return a float16 value, not a
> > float32 one. Fix that.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Agreed, though I don't think it has any effect on the results.

No, it doesn't have any effect on the results, but it produces slightly
less optimized code. The main problem there is that it fails to build
when enforcing type checking, though less and less targets are compiling
when it is enabled.

> Can we have the usual "ok under softfloat 2a or 2b license"
> confirmation, please?

Yes, I am fine to license this patch under softfloat 2a or 2b license.

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net