From: Paul Burton <paul@archlinuxmips.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>,
Paul Burton <paul@archlinuxmips.org>
Subject: Re: [Qemu-devel] [PATCH v2 15/16] linux-user: support the KDSIGACCEPT ioctl
Date: Sun, 22 Jun 2014 11:08:46 +0100 [thread overview]
Message-ID: <20140622100846.GE3158@gmail.com> (raw)
In-Reply-To: <CAFEAcA-06igoNfW5+O+6ka5Fxi7=MRpSBAv53fzSZrA=jcT_5w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Sun, Jun 22, 2014 at 12:13:27AM +0100, Peter Maydell wrote:
> > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> > index 309fb21..cd21e64 100644
> > --- a/linux-user/ioctls.h
> > +++ b/linux-user/ioctls.h
> > @@ -64,6 +64,7 @@
> > IOCTL(KDSKBLED, 0, TYPE_INT)
> > IOCTL(KDGETLED, 0, TYPE_INT)
> > IOCTL(KDSETLED, 0, TYPE_INT)
> > + IOCTL(KDSIGACCEPT, 0, TYPE_INT)
...snip...
>
> The argument to this ioctl is a signal number, right?
> Surely we need to translate it to a host signal number,
> not just pass it through as TYPE_INT...
True, not sure how I missed that - the clue is in the name!
Thanks,
Paul
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-22 10:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 22:52 [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements Paul Burton
2014-06-21 22:52 ` [Qemu-devel] [PATCH v2 01/16] linux-user: translate the result of getsockopt SO_TYPE Paul Burton
2014-06-21 22:52 ` [Qemu-devel] [PATCH v2 02/16] linux-user: support SO_ACCEPTCONN getsockopt option Paul Burton
2014-06-21 22:52 ` [Qemu-devel] [PATCH v2 03/16] linux-user: support SO_{SND, RCV}BUFFORCE setsockopt options Paul Burton
2014-06-21 22:52 ` [Qemu-devel] [PATCH v2 04/16] linux-user: support SO_PASSSEC setsockopt option Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 05/16] linux-user: allow NULL arguments to mount Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 06/16] linux-user: support strace of epoll_create1 Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 07/16] linux-user: fix struct target_epoll_event layout for MIPS Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday Paul Burton
2014-06-21 23:18 ` Peter Maydell
2014-06-22 10:11 ` Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 09/16] linux-user: allow NULL tv argument " Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 10/16] linux-user: support timerfd_{create, gettime, settime} syscalls Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 11/16] linux-user: support ioprio_{get, set} syscalls Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 12/16] linux-user: support {name_to, open_by}_handle_at syscalls Paul Burton
2014-06-27 13:26 ` Riku Voipio
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 13/16] linux-user: support the setns syscall Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 14/16] linux-user: support the unshare syscall Paul Burton
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 15/16] linux-user: support the KDSIGACCEPT ioctl Paul Burton
2014-06-21 23:13 ` Peter Maydell
2014-06-22 10:08 ` Paul Burton [this message]
2014-06-21 22:53 ` [Qemu-devel] [PATCH v2 16/16] linux-user: support the SIOCGIFINDEX ioctl Paul Burton
2014-06-27 13:30 ` [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements Riku Voipio
2014-08-05 11:33 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140622100846.GE3158@gmail.com \
--to=paul@archlinuxmips.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).