From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paulburton89@gmail.com>) id 1Wyek0-0006HX-AR
	for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:11:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paulburton89@gmail.com>) id 1Wyeju-0000Zo-0k
	for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:11:16 -0400
Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:42003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paulburton89@gmail.com>) id 1Wyejt-0000Zf-Pq
	for qemu-devel@nongnu.org; Sun, 22 Jun 2014 06:11:09 -0400
Received: by mail-wg0-f45.google.com with SMTP id l18so5334034wgh.4
	for <qemu-devel@nongnu.org>; Sun, 22 Jun 2014 03:11:09 -0700 (PDT)
Sender: Paul Burton <paulburton89@gmail.com>
Date: Sun, 22 Jun 2014 11:11:04 +0100
From: Paul Burton <paul@archlinuxmips.org>
Message-ID: <20140622101104.GF3158@gmail.com>
References: <1403391191-18603-1-git-send-email-paul@archlinuxmips.org>
	<1403391191-18603-9-git-send-email-paul@archlinuxmips.org>
	<CAFEAcA9Sv1xDRDbaP4ajDoTSA4qgZixaZqRmLq7mBWashsYxmg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="27ZtN5FSuKKSZcBU"
Content-Disposition: inline
In-Reply-To: <CAFEAcA9Sv1xDRDbaP4ajDoTSA4qgZixaZqRmLq7mBWashsYxmg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for
 settimeofday
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, QEMU Developers <qemu-devel@nongnu.org>, Paul Burton <paul@archlinuxmips.org>


--27ZtN5FSuKKSZcBU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 22, 2014 at 12:18:02AM +0100, Peter Maydell wrote:
> > +    if (!lock_user_struct(VERIFY_READ, target_tz, target_tz_addr, 1))
> > +        return -TARGET_EFAULT;
>=20
> Coding style mandates braces even on single-line if()s; checkpatch.pl
> will catch this usually.

I copied that style from the equivalent timeval functions, but yeah I'll
make sure to get into the habit of running checkpatch for QEMU patches.

> Code looks OK otherwise.

Thanks for looking,
    Paul

--27ZtN5FSuKKSZcBU
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJTpqu4AAoJENzvn0paErs5eFoP/24CrB+wKqFPeur59uGXlmAe
MQ1q9FOr/UpGVjhNfwwBp0Lw3sXMgd3I8Wcj2XhvBLfEnEMHEaRj9+hALkuWRRs0
E7joQqWZk8VkXFyYi9/ttHJlcxdJlyzPuC3KI2knJBC2qsxf5uFMUHyqIpOqPBX0
QyXLa32gdz7anmZa6dGCncNgUD+6aZ6fjBZAzTDz/eSuL6H2QiGfufu2l55xsKh+
woUTMo0xYw2rTL6RsWFfi5gYPMGGdsNee7Z95KSYHQNpD3e3E6TxLAZUKPtU+XQP
CQ7Fzys89Rs6j4SXEZ7LmkDrS7On8LLQ46w5bvr8VvmC7kYtU4rZMDXajDO+XyYy
SrDi6/kp0pSUqQqI0veFzGT+JoMlNSFzdU4X58lH9t5yHB9PgamEzbM8CaFCD+79
CihoZJ5qrCYClcs1ffn3mjjEe1pBEpB0+imIvuWBajWaq4QiQ2dPF+YxHyXDCOu/
qpvW6o5H5mGPCd5ocED3XgXbDn20DGKSQVV2X1E12l/DtXgx17LA3YsbVmknPh44
uc+gkz17YniCpTBXwbOEhnBMgY3lZ0OTD1Dp8BTwBNhtbprXXy8KbyCRMclAUeh6
zBl7lx0iAkLz3qeaWXlx/aybfl6KcFQSS04PhgS7QujsoLCeamdVHCihL2Bxmnuw
AYOMtkSj33TqJwkuIPO8
=4wMy
-----END PGP SIGNATURE-----

--27ZtN5FSuKKSZcBU--